Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about option experimental.WithRecvBufferPool #7517

Closed
wauxhall opened this issue Aug 16, 2024 · 2 comments
Closed

Question about option experimental.WithRecvBufferPool #7517

wauxhall opened this issue Aug 16, 2024 · 2 comments
Assignees

Comments

@wauxhall
Copy link

The comment says:
// Note: The shared buffer pool feature will not be active if any of the
// following options are used: WithStatsHandler, EnableTracing, or binary
// logging. In such cases, the shared buffer pool will be ignored.

So I'd like to know if there are any workarounds to use shared buffer with WithStatsHandler option? Or this is impossible at the moment? Perf tests show we really need this, but stats are also needed)))

I also can't find the code where options compatibility check is performed, I mean where is the code that checks if WithRecvBufferPool and WithStatsHandler are not used together.

Thanks!

@aranjans aranjans self-assigned this Aug 20, 2024
@purnesh42H purnesh42H assigned purnesh42H and unassigned aranjans Aug 20, 2024
@purnesh42H
Copy link
Contributor

@wauxhall there have been similar asks in the past #6660. Current state of API doesn't allow reuse of buffer with Stats handler. Some discussion https://github.com/grpc/grpc-go/pull/5862/files#r1171991389.

We're doing new memory sharing entirely, and this option will mostly be going away #7356

@wauxhall
Copy link
Author

Thanks a lot for your answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants