From fcf0dc15b1ced330c85959cec4d71772b4cc5698 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sun, 9 Jun 2024 16:47:46 +0100 Subject: [PATCH] require Node 18+ This is in prep for Puppeteer 22, which requires Node 18+. [1] grunt-contrib-internal does not yet have a version that provisions CI with Node 18+ matrix, which has delayed/complicated changes in this repo before as well so I'm going to opt-out from the contrib-ci template enforcement for now. This seems to be common in half a dozen other first-party grunt repos as well. [2] [1]: https://github.com/puppeteer/puppeteer/blob/puppeteer-v22.10.0/packages/puppeteer-core/CHANGELOG.md#2200-2024-02-05 [2]: https://github.com/search?q=skipIfExists%20org%3Agruntjs&type=code --- .github/workflows/test.yml | 2 +- Gruntfile.js | 2 +- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5860acf..2bad389 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,7 +20,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest] - node: [16, 18, 20] + node: [18, 20, 22] steps: - name: Clone repository diff --git a/Gruntfile.js b/Gruntfile.js index e9c1f9e..fc79986 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -231,6 +231,6 @@ module.exports = function(grunt) { grunt.registerTask('test', ['jshint', 'connect', 'qunit', 'shell', 'really-test']); // By default, lint and run all tests. - grunt.registerTask('default', ['test', 'build-contrib']); + grunt.registerTask('default', ['test', 'contrib-core', 'contrib-ci:skipIfExists']); }; diff --git a/package-lock.json b/package-lock.json index c1d298c..511aee5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,7 +23,7 @@ "qunit": "^2.19.4" }, "engines": { - "node": ">=16" + "node": ">=18" } }, "node_modules/@babel/code-frame": { diff --git a/package.json b/package.json index 1e4758a..676b8a7 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "repository": "gruntjs/grunt-contrib-qunit", "license": "MIT", "engines": { - "node": ">=16" + "node": ">=18" }, "main": "tasks/qunit.js", "scripts": {