Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesPathContain() produces wrong results #1477

Closed
c-f-h opened this issue Feb 29, 2016 · 3 comments
Closed

doesPathContain() produces wrong results #1477

c-f-h opened this issue Feb 29, 2016 · 3 comments

Comments

@c-f-h
Copy link

c-f-h commented Feb 29, 2016

This is node v5.7.0, grunt v0.4.5.

> var grunt = require('grunt');
undefined
> grunt.file.doesPathContain('/home', '/home/foo')
true
> grunt.file.doesPathContain('/home/foo', '/home/foo/bar')
false

What am I missing here?

@c-f-h
Copy link
Author

c-f-h commented Feb 29, 2016

Here's some more digging:

> path.relative('/home/foo/bar', '/home/foo')
'../../foo'
> path.relative('/home/foo', '/home')
'..'

@c-f-h
Copy link
Author

c-f-h commented Feb 29, 2016

Guess this is not the fault of you guys. Escalated it:

nodejs/node#5489

@shama
Copy link
Member

shama commented Feb 29, 2016

This has been fixed in node 5.7.1 and will be released shortly.

@shama shama closed this as completed Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants