Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave web.manifest display at default setting #2090

Closed
philwareham opened this issue Oct 24, 2018 · 4 comments · Fixed by #2096
Closed

Leave web.manifest display at default setting #2090

philwareham opened this issue Oct 24, 2018 · 4 comments · Fixed by #2096

Comments

@philwareham
Copy link

philwareham commented Oct 24, 2018

In the web.manifest, stating standalone is too opinionated, see https://developer.mozilla.org/en-US/docs/Web/Manifest#display

In this mode, the user agent will exclude UI elements for controlling navigation, but can include other UI elements such as a status bar.

Since html5-boilerplate is can be used for both apps and websites, changing the default display state (browser) to standalone opines that this is specifically a web app, removing UI beneficial to a website.

TLDR; omit display rule and leave it to default state browser. If a user wants to add "display": "standalone" themselves then they can

@roblarsen
Copy link
Member

roblarsen commented Oct 26, 2018

@coliff we re-added this property based on your testing, correct? I believe, based on that testing, we need this property. Should it be display:browser? That would be same as omitting it, but would validate.

@coliff
Copy link
Member

coliff commented Oct 29, 2018

We added "display": "standalone"to the manifest in PR #2060.

Not having display: defined in the manifest gives an error in Google Lighthouse's 'Progressive Web App' test, but really, it's not a problem at all if you're adding a manifest for improving the 'add site bookmark to homescreen' experience (manifests aren't purely intended for PWAs).

So I agree with @philwareham - we should remove it and I'll open a new PR for that now.

@roblarsen
Copy link
Member

👍

@coliff
Copy link
Member

coliff commented Oct 29, 2018

Opened a PR in #2096. I was wondering if we needed to update the docs, but I took a look at what we have currently:

Our site.webmanifest contains a very skeletal "app" definition, just to show the basic usage.
You should fill this file out with more information about your site or application

So I think we're good. It has a link to Mozilla's excellent docs for further info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants