This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Add checks for endpoint support and contract requirements #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oncleben31 this makes use of your contract implementation from hacf-fr/renault-api#145 Hopefully it should remove the ERROR and replace it with a WARNING. |
|
From my experience it's more an INFO. But I understood that it could be a way to notify an expired contract not renewed by error. In this second case it is more a warning. |
epenet
force-pushed
the
check-endpoint
branch
from
53e8edc
to
6294fb0
Compare
|
INFO on "support_endpoint" I don't think it's possible to differentiate easily between contract expired and contract missing |
epenet
force-pushed
the
check-endpoint
branch
from
6294fb0
to
61d207b
Compare
|
INFO on both... |
oncleben31
approved these changes
Jan 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #51