Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Captur 2 with Easylink #47

Merged
merged 10 commits into from
Nov 20, 2020
Merged

Adding Captur 2 with Easylink #47

merged 10 commits into from
Nov 20, 2020

Conversation

chino-lu
Copy link
Contributor

@chino-lu chino-lu commented Nov 20, 2020

  • only cockpit file had been available

Ref: #48

@epenet epenet added the ci Continuous Integration label Nov 20, 2020
@epenet
Copy link
Collaborator

epenet commented Nov 20, 2020

Thanks @chino-lu.
There are a few checks that need to pass:

  • json needs to be formatted (4 spaces identation)
  • json booleans need to be lower-case

There are also a few checks around hiding of personal data:

  • VIN needs to start with "VF1AAAAA555777"
  • registrationNumber needs to start with "REG-NUMBER"

json booleans need to be lower-case
VIN needs to start with "VF1AAAAA555777"
VIN needs to start with "VF1AAAAA555777"
registrationNumber needs to start with "REG-NUMBER"

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@epenet
Copy link
Collaborator

epenet commented Nov 20, 2020

Sorry - my mistake => json should have 2-spaces identation (not four spaces)

 json should have 2-spaces identation
2 spaces json formatting applied
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@epenet
Copy link
Collaborator

epenet commented Nov 20, 2020

I think I need to document the process better!
Maybe this will help future contributors: https://codebeautify.org/python-formatter-beautifier

@chino-lu
Copy link
Contributor Author

I am probably also worst case since it is the first time I am working with Github and all this stuff

@epenet
Copy link
Collaborator

epenet commented Nov 20, 2020

I tried to format it using pre-commit: pre-commit run --all-files

If you are using poetry, you can use poetry run pre-commit run --all-files

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@epenet
Copy link
Collaborator

epenet commented Nov 20, 2020

Aha => I mixed the beautifiers previously.
This one probably would have worked: https://codebeautify.org/jsonviewer

@epenet epenet merged commit a97a1f2 into hacf-fr:develop Nov 20, 2020
@epenet epenet added fixtures Provide fixtures and removed ci Continuous Integration labels Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixtures Provide fixtures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants