From f00b18f9c7e31d57fe9d8a07559e41018b07e0cf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joakim=20S=C3=B8rensen?= <ludeeus@ludeeus.dev>
Date: Sun, 4 Jun 2023 11:34:46 +0200
Subject: [PATCH] Remove hacs-link component (#654)

---
 .../dialogs/hacs-download-dialog.ts           |  1 -
 src/components/dialogs/hacs-generic-dialog.ts |  1 -
 src/components/hacs-link.ts                   | 53 -------------------
 src/panels/hacs-repository-panel.ts           | 17 ++++--
 src/styles/variables.ts                       |  3 --
 5 files changed, 12 insertions(+), 63 deletions(-)
 delete mode 100644 src/components/hacs-link.ts

diff --git a/src/components/dialogs/hacs-download-dialog.ts b/src/components/dialogs/hacs-download-dialog.ts
index d2f4d579..14027ca8 100644
--- a/src/components/dialogs/hacs-download-dialog.ts
+++ b/src/components/dialogs/hacs-download-dialog.ts
@@ -20,7 +20,6 @@ import { getRepositories, repositoryBeta, websocketSubscription } from "../../da
 import { HacsStyles } from "../../styles/hacs-common-style";
 import { generateLovelaceURL } from "../../tools/added-to-lovelace";
 import { updateLovelaceResources } from "../../tools/update-lovelace-resources";
-import "../hacs-link";
 import "./hacs-dialog";
 import { HacsDialogBase } from "./hacs-dialog-base";
 
diff --git a/src/components/dialogs/hacs-generic-dialog.ts b/src/components/dialogs/hacs-generic-dialog.ts
index d0dc3129..ed2b83d0 100644
--- a/src/components/dialogs/hacs-generic-dialog.ts
+++ b/src/components/dialogs/hacs-generic-dialog.ts
@@ -2,7 +2,6 @@ import { html, TemplateResult } from "lit";
 import { customElement, property } from "lit/decorators";
 import memoizeOne from "memoize-one";
 import "./hacs-dialog";
-import "../hacs-link";
 import { HacsDialogBase } from "./hacs-dialog-base";
 import { RepositoryBase } from "../../data/repository";
 import { markdownWithRepositoryContext } from "../../tools/markdown";
diff --git a/src/components/hacs-link.ts b/src/components/hacs-link.ts
deleted file mode 100644
index e8be79e7..00000000
--- a/src/components/hacs-link.ts
+++ /dev/null
@@ -1,53 +0,0 @@
-import { css, CSSResultGroup, html, LitElement, TemplateResult } from "lit";
-import { customElement, property } from "lit/decorators";
-import { mainWindow } from "../../homeassistant-frontend/src/common/dom/get_main_window";
-import { navigate } from "../../homeassistant-frontend/src/common/navigate";
-
-@customElement("hacs-link")
-export class HacsLink extends LitElement {
-  @property({ type: Boolean }) public newtab = false;
-
-  @property({ type: Boolean }) public parent = false;
-
-  @property() public title = "";
-
-  @property() public url!: string;
-
-  protected render(): TemplateResult | void {
-    return html`<span title=${this.title || this.url} @click=${this._open}><slot></slot></span>`;
-  }
-
-  private _open(): void {
-    if (this.url.startsWith("/") && !this.newtab) {
-      navigate(this.url, { replace: true });
-      return;
-    }
-    const external = this.url?.startsWith("http");
-    let features = "";
-    let target = "_blank";
-
-    if (external) {
-      features = "noreferrer=true";
-    }
-
-    if (!external && !this.newtab) {
-      target = "_blank";
-    }
-
-    if (!external && !this.parent) {
-      target = "_parent";
-    }
-
-    mainWindow.open(this.url, target, features);
-  }
-
-  static get styles(): CSSResultGroup {
-    return css`
-      span {
-        cursor: pointer;
-        color: var(--hcv-text-color-link);
-        text-decoration: var(--hcv-text-decoration-link);
-      }
-    `;
-  }
-}
diff --git a/src/panels/hacs-repository-panel.ts b/src/panels/hacs-repository-panel.ts
index 505d2b60..b61ffe1c 100644
--- a/src/panels/hacs-repository-panel.ts
+++ b/src/panels/hacs-repository-panel.ts
@@ -20,7 +20,6 @@ import "../../homeassistant-frontend/src/layouts/hass-error-screen";
 import "../../homeassistant-frontend/src/layouts/hass-loading-screen";
 import "../../homeassistant-frontend/src/layouts/hass-subpage";
 import { HomeAssistant, Route } from "../../homeassistant-frontend/src/types";
-import "../components/hacs-link";
 import { repositoryMenuItems } from "../components/hacs-repository-owerflow-menu";
 import { Hacs } from "../data/hacs";
 import { fetchRepositoryInformation, RepositoryBase, RepositoryInfo } from "../data/repository";
@@ -203,12 +202,16 @@ export class HacsRepositoryPanel extends LitElement {
                 : ""}
               ${authors
                 ? authors.map(
-                    (author) => html`<hacs-link .url="https://github.com/${author}">
+                    (author) => html`<a
+                      href="https://github.com/${author}"
+                      target="_blank"
+                      rel="noreferrer noopener"
+                    >
                       <ha-chip title="${this.hacs.localize("dialog_info.author")}" hasIcon>
                         <ha-svg-icon slot="icon" .path=${mdiAccount}></ha-svg-icon>
                         @${author}
                       </ha-chip>
-                    </hacs-link>`
+                    </a>`
                   )
                 : ""}
               ${this._repository.downloads
@@ -221,12 +224,16 @@ export class HacsRepositoryPanel extends LitElement {
                 <ha-svg-icon slot="icon" .path=${mdiStar}></ha-svg-icon>
                 ${this._repository.stars}
               </ha-chip>
-              <hacs-link .url="https://github.com/${this._repository.full_name}/issues">
+              <a
+                href="https://github.com/${this._repository.full_name}/issues"
+                target="_blank"
+                rel="noreferrer noopener"
+              >
                 <ha-chip title="${this.hacs.localize("dialog_info.open_issues")}" hasIcon>
                   <ha-svg-icon slot="icon" .path=${mdiExclamationThick}></ha-svg-icon>
                   ${this._repository.issues}
                 </ha-chip>
-              </hacs-link>
+              </a>
             </div>
             <ha-markdown
               .content=${markdownWithRepositoryContext(
diff --git a/src/styles/variables.ts b/src/styles/variables.ts
index 34a64457..53aefdfb 100644
--- a/src/styles/variables.ts
+++ b/src/styles/variables.ts
@@ -15,8 +15,5 @@ export const hacsStyleVariables = css`
 
     --mdc-dialog-heading-ink-color: var(--hcv-text-color-primary);
     --mdc-dialog-content-ink-color: var(--hcv-text-color-primary);
-
-    /*hacs-link*/
-    --hcv-text-decoration-link: var(--hacs-link-text-decoration, none);
   }
 `;