Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a "Start Minimized" functionality. #285

Merged
merged 2 commits into from
Jan 20, 2024
Merged

Adding a "Start Minimized" functionality. #285

merged 2 commits into from
Jan 20, 2024
+53 −3

Conversation

Meedtone
Copy link
Contributor

Tested on Windows 11 22H2, Electron 6.1.5
Addresses #169

Notes:

  • Option only shows when "Show Tray Icon" is on.
  • Increased the window height slightly to prevent scrollbar from showing.
  • Variable show from createWindow() now defaults to false.
  • Opted for win.close() instead of win.minimize() when minimizing to tray.
  • Removed the last else if statement in main.js line 322 because I couldn't get it to work otherwise lol. Things seem to work fine though.

Preview Screenshots:
s1
s2

NotLazy
NotLazy reviewed Jan 17, 2024
View reviewed changes
src/app.html Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to reduce clutter we could put this in the tray dropdown since that's where enabling start at boot is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that seems better actually lol. Will update.

@Meedtone
Added "Start Minimized" functionality.
a1b8335 
Changes to be committed:
	modified:   src/app.html
	modified:   src/app.js
	modified:   src/main.js
@Meedtone
Moved "Start Minimized" to the tray menu
1f50f0b 
Changes to be committed:
	modified:   src/app.html
	modified:   src/app.js
	modified:   src/main.js
	new file:   src/utils/start_minimized_handler.js
NotLazy
NotLazy approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@NotLazy NotLazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change on macOS and it looks to be working great.

I thought there might be an issue with running the app twice not opening the app window, but it works as expected, and the window does open when running the app twice.

Great work.

@NotLazy NotLazy merged commit 4d818db into hainguyents13:master Jan 20, 2024
@NotLazy NotLazy mentioned this pull request Jan 20, 2024
Closed
@NotLazy NotLazy mentioned this pull request Jan 30, 2024
Closed
NotLazy pushed a commit to NotLazy/mechvibes that referenced this pull request Feb 17, 2024
@Meedtone @NotLazy
Adding a "Start Minimized" toggle (hainguyents13#285)
232fe5f
@battlelitany battlelitany mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotLazy NotLazy NotLazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meedtone @NotLazy