Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple pages of records? #26

Open
pwcarney opened this issue Jun 20, 2022 · 3 comments
Open

Multiple pages of records? #26

pwcarney opened this issue Jun 20, 2022 · 3 comments

Comments

@pwcarney
Copy link

I noticed the player profile page only has one page of records, the last X games. Is there a data storage reason for that? Or could that be a potential future feature?

@halvnykterist
Copy link
Owner

The primary reason for that is to speed up rendering the page (and to not make it too long.) Having multiple pages of records is definitely something I've got as an idea, but haven't implemented yet.

A temporary workaround is to add /history?game_count=9999 to the URL to get an extended unstyled view..

@pwcarney
Copy link
Author

pwcarney commented Jun 21, 2022 via email

@halvnykterist
Copy link
Owner

Sounds good! I think all that really needs to be done is to add an offset field to the history getter and in the SQL, then doing the appropriate history pull with JS on the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants