Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMException will be a global in Node.js 17+ #1019

Closed
targos opened this issue Aug 22, 2021 · 2 comments · Fixed by #1020
Closed

DOMException will be a global in Node.js 17+ #1019

targos opened this issue Aug 22, 2021 · 2 comments · Fixed by #1020
Assignees
Labels
feature New functionality or improvement
Milestone

Comments

@targos
Copy link

targos commented Aug 22, 2021

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): no

Context

  • node version: v17.0.0-pre
  • module version with issue: latest
  • last module version without issue: none
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): @hapi/shot
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

Run tests of @hapi/shot with prerelease of Node.js 17

What was the result you got?

The following leaks were detected:DOMException

https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu1804-64/2751/testReport/junit/(root)/citgm/_hapi_shot_v5_0_5/

What result did you expect?

No leak detected

@targos targos added the support Questions, discussions, and general support label Aug 22, 2021
@Nargonath
Copy link
Member

Alright, thanks @targos for the heads-up.

@Nargonath Nargonath added feature New functionality or improvement and removed support Questions, discussions, and general support labels Aug 23, 2021
@targos
Copy link
Author

targos commented Aug 25, 2021

nodejs/node#39759 is about to land, so there will also probably be structuredClone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants