Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail items not counted when images are missing #17

Open
nshores opened this issue Sep 7, 2018 · 0 comments
Open

Mail items not counted when images are missing #17

nshores opened this issue Sep 7, 2018 · 0 comments

Comments

@nshores
Copy link
Contributor

nshores commented Sep 7, 2018

I'm going to be handling this, but I wanted to point out the fact that the code for counting mail items relies on a image being present for the mail item in question. Many times, there will be mail items present without a scanned image. The current logic for checking for mail items assumes a image will always be present.

for row in parsed.find_all('div', {'class': 'mailpiece'}):
    image = _get_mailpiece_image(row)
    if not image:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant