Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue when usin bootstrap modal esc keypress #2653

Closed
wkjesus opened this issue Jul 22, 2016 · 1 comment · Fixed by #2713
Closed

issue when usin bootstrap modal esc keypress #2653

wkjesus opened this issue Jul 22, 2016 · 1 comment · Fixed by #2713

Comments

@wkjesus
Copy link

wkjesus commented Jul 22, 2016

i found a solution , hopes implement on future release;
the situation is when using bootstrap modal, and shows chosen item, if press esc key, both modal and chosen close,,, expected only chosen hide, and modal stills i modifed
i use stoppropagation.
the calls con keyup_checker and keydown_checker and put this lines:
[keydown_checker]
case 27:
if (this.results_showing) {
evt.stopPropagation();
this.results_hide();
}
return true;

[keyup_checker]
case:27
if (this.results_showing) {
evt.stopPropagation();
this.results_hide();
}
return true;

@koenpunt
Copy link
Collaborator

Would you mind creating a pull request for this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants