Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running tests creates ~/.vault-token file which changes future behavior #1353

Closed
eikenb opened this issue Mar 4, 2020 · 4 comments
Closed

Running tests creates ~/.vault-token file which changes future behavior #1353

eikenb opened this issue Mar 4, 2020 · 4 comments
Labels
bug vault Related to the Vault integration
Milestone
0.25.0

Comments

@eikenb
Copy link
Contributor

eikenb commented Mar 4, 2020

It is a side effect of running vault. You can reproduce it by running vault server -dev.

Look into a way to disable this or add a cleanup method. Having it do this messes with manual testing if you forget about it (which I have).
@eikenb eikenb added bug vault Related to the Vault integration labels Mar 4, 2020
@eikenb
Copy link
Contributor Author

eikenb commented Mar 4, 2020

Found the option that disables it. I'm asking the vault people if there would be any unintended consequences of setting this in our integration tests so they'd stop creating that file.

  -dev-no-store-token
      Do not persist the dev root token to the token helper (usually the local
      filesystem) for use in future requests. The token will only be displayed
      in the command output. The default is false.

@eikenb
Copy link
Contributor Author

eikenb commented Mar 4, 2020

Vault people confirmed no worries. We can disable it.

@eikenb eikenb added this to the 0.25.0 milestone Mar 4, 2020
@findkim findkim self-assigned this Mar 5, 2020
@eikenb eikenb closed this as completed in ee25ee4 Mar 5, 2020
@findkim findkim removed their assignment Mar 5, 2020
@eikenb
Copy link
Contributor Author

eikenb commented Mar 5, 2020

@findkim I missed that you had assigned this to yourself. Sorry about that.

@findkim
Copy link
Contributor

findkim commented Mar 6, 2020

No worries! happy that it's resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug vault Related to the Vault integration
Projects
None yet
Milestone
0.25.0
Development

No branches or pull requests
2 participants
@eikenb @findkim