Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal path foo errors with 'man' doesn't take any extra arguments: foo #9755

Closed
andreasabel opened this issue Feb 29, 2024 · 3 comments · Fixed by #9583
Closed

cabal path foo errors with 'man' doesn't take any extra arguments: foo #9755

andreasabel opened this issue Feb 29, 2024 · 3 comments · Fixed by #9583
Labels
re: error-message Concerning error messages delivered to the user type: bug

Comments

@andreasabel
Copy link
Member

On current master:

$ cabal path foo
Error: [Cabal-7061]
'man' doesn't take any extra arguments: foo

This is a cut-and-paste coding error in PR

pathAction :: PathFlags -> [String] -> Action
pathAction pathflags extraArgs globalFlags = do
let verbosity = fromFlag (pathVerbosity pathflags)
unless (null extraArgs) $
dieWithException verbosity $
ManpageAction extraArgs

Copied from here:
manpageAction :: [CommandSpec action] -> ManpageFlags -> [String] -> Action
manpageAction commands flags extraArgs _ = do
let verbosity = fromFlag (manpageVerbosity flags)
unless (null extraArgs) $
dieWithException verbosity $
ManpageAction extraArgs

ATTN: @athas

@andreasabel andreasabel added type: bug re: error-message Concerning error messages delivered to the user labels Feb 29, 2024
@fendor
Copy link
Collaborator

fendor commented Feb 29, 2024

Perhaps interesting, # 4661 #9583 refactors cabal path, and I think it fixes this particular error as well.

EDIT: I linked the wrong number

@athas
Copy link
Collaborator

athas commented Feb 29, 2024

Oh yeah, that's just a copy/paste error. Is it worth fixing if #9583 rewrites the command entirely?

@andreasabel andreasabel linked a pull request Mar 4, 2024 that will close this issue
5 tasks
@andreasabel
Copy link
Member Author

Is it worth fixing if #9583 rewrites the command entirely?

We can hold off any activity here until #9583 lands, I'd say. I linked the latter as fixing this issue here.

@mergify mergify bot closed this as completed in #9583 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: error-message Concerning error messages delivered to the user type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants