{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":143212778,"defaultBranch":"cmake-staging","name":"bitcoin","ownerLogin":"hebasto","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-08-01T21:59:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/32963518?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1727437908.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"f1daa80521eccebe86af6ee6fa594edf40eaa676","ref":"refs/heads/240927-guix-path","pushedAt":"2024-09-27T11:51:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"guix: Drop no longer needed `PATH` modification","shortMessageHtmlLink":"guix: Drop no longer needed PATH modification"}},{"before":"381ab148dc97fca4dbb4632cc3a2d902defcef49","after":null,"ref":"refs/heads/240921-guix-mp.DEMO.repro","pushedAt":"2024-09-27T10:46:20.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"d8ec933456bc7e63306b9cb8aa51ad93e215dc51","after":null,"ref":"refs/heads/240921-guix-mp.DEMO","pushedAt":"2024-09-27T10:46:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"06b4c339e89e593d951a90cd2d1bce944acf3bf7","after":null,"ref":"refs/heads/240921-guix-mp","pushedAt":"2024-09-27T10:45:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"fa7c2838a5f3693c6831b29a9c849a66506d1663","after":"d812cf11896a2214467b6fa72d7b763bac6077c5","ref":"refs/heads/master","pushedAt":"2024-09-27T10:44:32.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30879: test: re-bucket long-running tests\n\nf5a2000579b140a1f51fc433706c775ca560c62c test: re-bucket long-running tests (willcl-ark)\n\nPull request description:\n\n Re-bucket:\n\n - `p2p_node_network_limited -v*transport`\n - `feature_assume_utxo`\n\n On CI runners these tests are taking longer than their current bucket suggests, often being among the last to finish.\n\n Re-bucket them to improve CI efficiency.\n\nACKs for top commit:\n maflcko:\n review ACK f5a2000579b140a1f51fc433706c775ca560c62c\n\nTree-SHA512: 3da5c888db64a311276338270ba1dcad3eb2a24e205f6bb86fc92f767ecfa63682f13fafffff569fa0cfaea607ccb538f31e3934a086d482c3fe1be5d39f8791","shortMessageHtmlLink":"Merge bitcoin#30879: test: re-bucket long-running tests"}},{"before":"d5af7d28f475c0e579629a9b432c2b8a35075048","after":"fa7c2838a5f3693c6831b29a9c849a66506d1663","ref":"refs/heads/master","pushedAt":"2024-09-26T15:44:11.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30948: test: Add missing sync_mempools() to fill_mempool()\n\nfaf801515f8fcd11a3454105cab66c38f6f240fe test: Add missing sync_mempools() to fill_mempool() (MarcoFalke)\nfa48be6f0233cfbd5c1eab7b832c913912062fa5 test: Refactor fill_mempool to extract send_batch helper (MarcoFalke)\n\nPull request description:\n\n Not doing the sync will lead to (intermittent) issues, as explained in https://github.com/bitcoin/bitcoin/issues/30922#issuecomment-2364529013.\n\n Fix all issues by doing the sync by default and disable it in places that do not need the sync.\n\n Fixes #30922\n\nACKs for top commit:\n mzumsande:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n ismaelsadeeq:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n marcofleon:\n Tested ACK faf801515f8fcd11a3454105cab66c38f6f240fe\n\nTree-SHA512: 2de62d168cbb6857a9fb8bc12c42a9093fedf5e9beb6f83a32b3fa72a5ba3cf03631055fd25ef553399a27a6fe0d71c44cfe60660a4d31986debd13b8ab00228","shortMessageHtmlLink":"Merge bitcoin#30948: test: Add missing sync_mempools() to fill_mempool()"}},{"before":"4cf84b344dea4696de540a0f053aa1ec560ac38c","after":null,"ref":"refs/heads/240926-mp-deps","pushedAt":"2024-09-26T11:25:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"}},{"before":"e13da501db9e123ec56adfcb6f01b811445f9ce7","after":"d5af7d28f475c0e579629a9b432c2b8a35075048","ref":"refs/heads/master","pushedAt":"2024-09-26T11:25:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30976: depends, doc: Drop package-specific note about CMake\n\n4cf84b344dea4696de540a0f053aa1ec560ac38c depends, doc: No need to specify general requirement (Hennadii Stepanov)\n\nPull request description:\n\n CMake is no longer required solely for `libmultiprocess`.\n\nACKs for top commit:\n maflcko:\n review ACK 4cf84b344dea4696de540a0f053aa1ec560ac38c\n\nTree-SHA512: 014808ef523d6f0101aaa52a1858bebc16da9eb44664beb204e271b033c4dfa48115ce85c4ce5f151e82f90f83c64aaa25af73ef5a9b9b64953d2e07ff19633f","shortMessageHtmlLink":"Merge bitcoin#30976: depends, doc: Drop package-specific note about C…"}},{"before":null,"after":"4cf84b344dea4696de540a0f053aa1ec560ac38c","ref":"refs/heads/240926-mp-deps","pushedAt":"2024-09-26T10:58:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"depends, doc: No need to specify general requirement\n\nCMake is no longer required solely for `libmultiprocess`.","shortMessageHtmlLink":"depends, doc: No need to specify general requirement"}},{"before":"4cf84b344dea4696de540a0f053aa1ec560ac38c","after":"e13da501db9e123ec56adfcb6f01b811445f9ce7","ref":"refs/heads/master","pushedAt":"2024-09-26T10:58:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example\n\n286725168ae0309e427b1204a0724a4ba7cbe860 doc: fix loadtxoutset example (fanquake)\n\nPull request description:\n\n The current order is incorrect:\n ```bash\n ./build/src/bitcoin-cli loadtxoutset -rpcclienttimeout=0 utxo-840000.dat\n error code: -1\n error message:\n loadtxoutset \"path\"\n ```\n\nACKs for top commit:\n maflcko:\n review ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n theStack:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n BrandonOdiwuor:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n\nTree-SHA512: cc58b94ccdbf5b3925af1e9cbebbe5f1ed9d0ad1bad4c0d1acd2482b39edebb43a811576d3fb0dca66d2a98e13a8ffd7c9754fda62121beb674dee115f984346","shortMessageHtmlLink":"Merge bitcoin#30973: doc: fix loadtxoutset example"}},{"before":"e13da501db9e123ec56adfcb6f01b811445f9ce7","after":"4cf84b344dea4696de540a0f053aa1ec560ac38c","ref":"refs/heads/master","pushedAt":"2024-09-26T10:57:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"depends, doc: No need to specify general requirement\n\nCMake is no longer required solely for `libmultiprocess`.","shortMessageHtmlLink":"depends, doc: No need to specify general requirement"}},{"before":"513b7136c798e43899a2a3843e35b5696be2be29","after":"e13da501db9e123ec56adfcb6f01b811445f9ce7","ref":"refs/heads/master","pushedAt":"2024-09-26T10:53:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30973: doc: fix `loadtxoutset` example\n\n286725168ae0309e427b1204a0724a4ba7cbe860 doc: fix loadtxoutset example (fanquake)\n\nPull request description:\n\n The current order is incorrect:\n ```bash\n ./build/src/bitcoin-cli loadtxoutset -rpcclienttimeout=0 utxo-840000.dat\n error code: -1\n error message:\n loadtxoutset \"path\"\n ```\n\nACKs for top commit:\n maflcko:\n review ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n theStack:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n BrandonOdiwuor:\n ACK 286725168ae0309e427b1204a0724a4ba7cbe860\n\nTree-SHA512: cc58b94ccdbf5b3925af1e9cbebbe5f1ed9d0ad1bad4c0d1acd2482b39edebb43a811576d3fb0dca66d2a98e13a8ffd7c9754fda62121beb674dee115f984346","shortMessageHtmlLink":"Merge bitcoin#30973: doc: fix loadtxoutset example"}},{"before":"39219fe145e5e6e6f079b591e3f4b5fea8e71804","after":"513b7136c798e43899a2a3843e35b5696be2be29","ref":"refs/heads/master","pushedAt":"2024-09-26T09:08:26.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30961: ci: add `LLVM_SYMBOLIZER_PATH` to Valgrind fuzz job\n\nc1832584bfd1b352095bc41a13ff17564e456d43 ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job (fanquake)\n\nPull request description:\n\n Otherwise:\n ```bash\n NEW_FUNC[1/23]: ==4710==WARNING: invalid path to external symbolizer!\n ==4710==WARNING: Failed to use and restart external symbolizer!\n 0xb72010 (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a010) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)\n NEW_FUNC[2/23]: 0xb72240 (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a240) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)\n\n ```\n\nACKs for top commit:\n maflcko:\n review ACK c1832584bfd1b352095bc41a13ff17564e456d43\n\nTree-SHA512: 73d042c7432edac63704912391351770648fe9aef3c6dabe05dfc0b52a84cc1c4a3f1a5f8e36854238abe6097f9e5d571e19060ed040c59f45fe97c432330b3b","shortMessageHtmlLink":"Merge bitcoin#30961: ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job"}},{"before":"a9773b6215e1ee66203680ac7d0b2aae0d797f95","after":"39219fe145e5e6e6f079b591e3f4b5fea8e71804","ref":"refs/heads/master","pushedAt":"2024-09-25T11:23:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30946: doc: correct the zmq automatic build info\n\n06e7e83632985bd8b648d24f9a51591d3a3bbec3 doc: correct the zmq automatic build info (tdb3)\n\nPull request description:\n\n The current documentation states that the ZMQ feature is automatically included when building.\n Noticed this was no longer the case when building to review PR #30942.\n\nACKs for top commit:\n l0rinc:\n ACK 06e7e83632985bd8b648d24f9a51591d3a3bbec3\n hebasto:\n re-ACK 06e7e83632985bd8b648d24f9a51591d3a3bbec3.\n\nTree-SHA512: 24269c29415e54815b105e3f830f31f055e9bdcb3bf4a7cede068651875190adfc4e72ad5448b3c30a23b0db024f743d9f18576a6fda46d87deb5ea39352e626","shortMessageHtmlLink":"Merge bitcoin#30946: doc: correct the zmq automatic build info"}},{"before":"393f323bd60b9d47be697820a7ddf075700a7273","after":"a9773b6215e1ee66203680ac7d0b2aae0d797f95","ref":"refs/heads/master","pushedAt":"2024-09-25T10:38:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30963: doc: Adjust links in OSS-Fuzz section\n\nfa6c1946d235c6ea5b9384d8488d80aa3bcd0ad7 doc: Adjust links in OSS-Fuzz section (MarcoFalke)\n\nPull request description:\n\n Adjust the links after the google issue tracker migration and replace the remaining paragraph with a link to https://bitcoincore.org/en/security-advisories/\n\nACKs for top commit:\n dergoegge:\n ACK fa6c1946d235c6ea5b9384d8488d80aa3bcd0ad7\n\nTree-SHA512: 4c3aba8bb5641756be5c66c2ee21b927a675622ddac021303f8196a1b2d8eb891406f6dedab0f04e12312339953c87302891df4ad5f5956c0b2ddd453452e1c9","shortMessageHtmlLink":"Merge bitcoin#30963: doc: Adjust links in OSS-Fuzz section"}},{"before":"90a5786bba4baac1c0270e1f4bf5bb8c790e10de","after":"393f323bd60b9d47be697820a7ddf075700a7273","ref":"refs/heads/master","pushedAt":"2024-09-24T20:07:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30952: test: Use shell builtins in run_command test case\n\n7bd3ee62f6d6f59ca599e85f81776d282dee1539 test: Use shell builtins in run_command test case (Ava Chow)\n\nPull request description:\n\n Uses the [suggested command](https://github.com/bitcoin/bitcoin/issues/30938#issuecomment-2363906135)\n\n Fixes #30938\n\nACKs for top commit:\n maflcko:\n review ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539\n hebasto:\n ACK 7bd3ee62f6d6f59ca599e85f81776d282dee1539.\n\nTree-SHA512: 683b15cafaf0103eeadf872ea6ce9a7d884b2605d3dcf4e66b0173cdb149c24965e7c5fa62aaddf2ac55df3f449aeb787176992c96cfee5d0b86621259e1dfe9","shortMessageHtmlLink":"Merge bitcoin#30952: test: Use shell builtins in run_command test case"}},{"before":"c767ef068be490ac48374bb88092938a71944c1c","after":"7a1b1417f9c1154e92e26221aab246197faf1393","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T17:45:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"haha","shortMessageHtmlLink":"haha"}},{"before":"3a6b5091f52e8665290b3993185bd6a772dabcef","after":"c767ef068be490ac48374bb88092938a71944c1c","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T17:34:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"guix: Adjust `symbol-check.py`","shortMessageHtmlLink":"guix: Adjust symbol-check.py"}},{"before":"2a2d938c2f3dfc3a2d870a66640b721680e24891","after":"3a6b5091f52e8665290b3993185bd6a772dabcef","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T17:23:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"A fix for Guix?","shortMessageHtmlLink":"A fix for Guix?"}},{"before":"1e522751b47e8d014b0474e64c2a515fa566593f","after":"2a2d938c2f3dfc3a2d870a66640b721680e24891","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T17:17:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"debug it","shortMessageHtmlLink":"debug it"}},{"before":"d6baec0c65e4b5cb4e0c231c138ce05c70e88815","after":"1e522751b47e8d014b0474e64c2a515fa566593f","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T17:02:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Patch Linguist feature","shortMessageHtmlLink":"Patch Linguist feature"}},{"before":null,"after":"d6baec0c65e4b5cb4e0c231c138ce05c70e88815","ref":"refs/heads/240924-qt6-cross.0","pushedAt":"2024-09-24T16:08:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Remove `qttools.mk`","shortMessageHtmlLink":"Remove qttools.mk"}},{"before":"7046e749ebc06cc722ed931ef4f02da6cc9a3d95","after":"3da895ea6f35cafdfadc427ccca77dfa30b03d11","ref":"refs/heads/240924-qt6+tools.1","pushedAt":"2024-09-24T15:30:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Enable Network","shortMessageHtmlLink":"Enable Network"}},{"before":"540fb541d6f72b7a3246766e4d934a8196542b2a","after":"7046e749ebc06cc722ed931ef4f02da6cc9a3d95","ref":"refs/heads/240924-qt6+tools.1","pushedAt":"2024-09-24T14:34:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Dry it as much as possible","shortMessageHtmlLink":"Dry it as much as possible"}},{"before":null,"after":"540fb541d6f72b7a3246766e4d934a8196542b2a","ref":"refs/heads/240924-qt6+tools.1","pushedAt":"2024-09-24T14:25:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Fix Guix build `env HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build`\n\nERROR: Feature \"xcb\": Forcing to \"ON\" breaks its condition:\n QT_FEATURE_thread AND TARGET XCB::XCB AND TEST_xcb_syslibs AND QT_FEATURE_xkbcommon_x11\nCondition values dump:\n QT_FEATURE_thread = \"ON\"\n TARGET XCB::XCB found\n TEST_xcb_syslibs = \"\"\n QT_FEATURE_xkbcommon_x11 not evaluated","shortMessageHtmlLink":"Fix Guix build env HOSTS=x86_64-linux-gnu ./contrib/guix/guix-build"}},{"before":null,"after":"b7a28a3a9690d2d9b4663bafc82b3a01032f9a79","ref":"refs/heads/240924-qt6+tools.0","pushedAt":"2024-09-24T14:12:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"clean up","shortMessageHtmlLink":"clean up"}},{"before":"33adc7521cc8bb24b941d959022b084002ba7c60","after":"90a5786bba4baac1c0270e1f4bf5bb8c790e10de","ref":"refs/heads/master","pushedAt":"2024-09-24T10:28:12.000Z","pushType":"push","commitsCount":18,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30678: wallet: Write best block to disk before backup\n\nf20fe33e94c6752e5d2ed92511c0bf51a10716ee test: Add basic balance coverage to wallet_assumeutxo.py (Fabian Jahr)\n037b101e808ccf9e717751619e04f6e87d614efd test: Add coverage for best block locator write in wallet_backup (Fabian Jahr)\n31c0df038909e40fe9618a4595254907ed1de907 wallet: migration, write best locator before unloading wallet (furszy)\n7e3dbe4180cbeb65e59b53d9fa98509e9189549d wallet: Write best block to disk before backup (Fabian Jahr)\n\nPull request description:\n\n I discovered that we don't write the best block to disk when trying to explain the behavior described here: https://github.com/bitcoin/bitcoin/pull/30455#discussion_r1719951882\n\n In the context of that test, the behavior is confusing and I think it also shows that one of the already existing tests in `wallet_assumeutxo.py` doesn't actually test what it says. It only fails because the best block isn't written and actually, the height of the backup that is loaded is at the snapshot height during backup. So it really shouldn't fail since it's past the background sync blocks already.\n\n I'm not sure if this is super relevant in practice though so I am first looking for concept ACKs on the `BackupWallet` code change. Either way, I think this behavior should be documented better if it is left as is and the test should be changed.\n\nACKs for top commit:\n achow101:\n ACK f20fe33e94c6752e5d2ed92511c0bf51a10716ee\n furszy:\n ACK f20fe33\n\nTree-SHA512: bb384a940df5c942fffe2eb06314ade4fc5d9b924012bfef3b1c456c4182a30825d1e137d8ae561d93d3a8a2f4d1c1ffe568132d20fa7d04844f1e289ab4a28b","shortMessageHtmlLink":"Merge bitcoin#30678: wallet: Write best block to disk before backup"}},{"before":"69ecc6edd9ad2a5ce15d56232303abbafbf4f68a","after":"382c858fbfef25f51b56355546f7e477e5a0d341","ref":"refs/heads/240923-qt6-cross.1","pushedAt":"2024-09-23T23:42:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Add `-qt-host-path` everywhere (2)","shortMessageHtmlLink":"Add -qt-host-path everywhere (2)"}},{"before":"862d7b1e637ecb1aa775d21f8c667608a89ea1dd","after":"69ecc6edd9ad2a5ce15d56232303abbafbf4f68a","ref":"refs/heads/240923-qt6-cross.1","pushedAt":"2024-09-23T23:37:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Add `-qt-host-path` everywhere","shortMessageHtmlLink":"Add -qt-host-path everywhere"}},{"before":"c851c13f7742f43d08440e2ed780dbdd2e1b89c9","after":"862d7b1e637ecb1aa775d21f8c667608a89ea1dd","ref":"refs/heads/240923-qt6-cross.1","pushedAt":"2024-09-23T23:13:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hebasto","name":"Hennadii Stepanov","path":"/hebasto","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32963518?s=80&v=4"},"commit":{"message":"Fixup assignments","shortMessageHtmlLink":"Fixup assignments"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yN1QxMTo1MTo0OC4wMDAwMDBazwAAAATCi9_U","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yM1QyMzoxMzowMi4wMDAwMDBazwAAAAS-hOZs"}},"title":"Activity · hebasto/bitcoin"}