Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #292: cmake: Fix
toolchain.cmake
for *BSD systems
20ef783 fixup! build: Generate `toolchain.cmake` in depends (Hennadii Stepanov) Pull request description: For *BSD systems, the `qt` and `qrencode` packages are not built, even without the `NO_QT` or `NO_QR` variables defined, because these package are not available for the host systems: https://github.com/hebasto/bitcoin/blob/19d4d920d97aa7fc4675eb4ac4ecf744e9ec8613/depends/packages/packages.mk#L7-L13 We already handle the exact logic for the `systemtap` (USDT) package. Therefore, it is reasonable to use this working logic uniformly for all cases. Additionally, this PR correctly handles cases when a `*_packages_` variable contains only spaces rather than being empty. --- How to test this PR on a *BSD system: 1. Build depends following the build guides (`depends/README.md`, `doc/build-*bsd.md`) 2. Configure the main build system using the generated toolchain file: ``` cmake -B build --toolchain depends/<your-platform>/toolchain.cmake ``` It fails. With this PR it configures successfully. ACKs for top commit: vasild: ACK 20ef783 Tree-SHA512: 901770884fea57c1b4439f8eaaf0399d753840730caeaaf79eb77e23a1292ef28703e445e7f43a94eda59160b765a37e2ac56ca30a3e961038ba4bbe0fe473ce
- Loading branch information