cmake: Check -D_FORTIFY_SOURCE before applying
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses @fanquake's offline comment:
|
Check `-D_FORTIFY_SOURCE` before applying.
hebasto
changed the title
-D_FORTIFY_SOURCE before applying.-D_FORTIFY_SOURCE before applying
|
ACK e88bfeb I can see in the configure output that the flags have been set and I saw in CMakeConfigureLog.yaml that they were correctly passed to compiler and linker to check that there are no warnings with their use. /usr/bin/c++ -DCXX_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Werror -std=c++20 -fPIC -o CMakeFiles/cmTC_26374.dir/src.cxx.o -c /bitcoin/build/CMakeFiles/CMakeScratch/TryCompile-0M3Cih/src.cxx |
m3dwards
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
-D_FORTIFY_SOURCEbefore applying.This PR follows the master branch behaviour.