forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Drop no longer needed code to handle ENV unsetting #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My Guix build:
|
hebasto
added
enhancement
New feature or request
port from autotools
Ported from the main repository
labels
Jul 30, 2024
hebasto
changed the title
cmake: Port PR30451 and drop code to handle ENV unsetting
cmake: Drop no longer needed code to handle ENV unsetting
Jul 31, 2024
Rebased. |
My Guix build:
|
ACK 4edb2e9 Much simpler x86_64 guix build 5ddf1e5eefab44bd2fdc8fb27e952a340eb58fd76a286680718ab6564dce7e32 guix-build-4edb2e9424d1/output/arm64-apple-darwin/SHA256SUMS.part
d9fec1b122cb9790386c19ec3ba29bda32497403c1936dc795ce8a59a9d29f19 guix-build-4edb2e9424d1/output/arm64-apple-darwin/bitcoin-4edb2e9424d1-arm64-apple-darwin-unsigned.tar.gz
19c129e23e00b447058731a54ea7a5ae17b4ec254615404d699001384e2cfd9d guix-build-4edb2e9424d1/output/arm64-apple-darwin/bitcoin-4edb2e9424d1-arm64-apple-darwin-unsigned.zip
96cf975c6dc4613e8f834409843f4ad9e0866afc819f609cc5ebde0c3d8c431f guix-build-4edb2e9424d1/output/arm64-apple-darwin/bitcoin-4edb2e9424d1-arm64-apple-darwin.tar.gz
3b3dceefb41401c9ab23293341d7358b3d7cbede5e94d8de17269a3b36623880 guix-build-4edb2e9424d1/output/dist-archive/bitcoin-4edb2e9424d1.tar.gz
b4bf90184688fef61c99a99bde1d681f125302907f36631934c396c4aef81396 guix-build-4edb2e9424d1/output/x86_64-apple-darwin/SHA256SUMS.part
403c6fa7c8dc01beb243437ea466186dbc4ed09e64e4cfac36181dde1479ec9f guix-build-4edb2e9424d1/output/x86_64-apple-darwin/bitcoin-4edb2e9424d1-x86_64-apple-darwin-unsigned.tar.gz
d23d3fbe5404453d7ef45fc6cff8bdf1eca4e5ed799760cf556b1603f22feddc guix-build-4edb2e9424d1/output/x86_64-apple-darwin/bitcoin-4edb2e9424d1-x86_64-apple-darwin-unsigned.zip
3fc51c53968601434779ed607fd7243c796e4b9caa93dcc00b499efb81a0b762 guix-build-4edb2e9424d1/output/x86_64-apple-darwin/bitcoin-4edb2e9424d1-x86_64-apple-darwin.tar.gz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bitcoin#30451 allows to simplify the CMake code.
This PR drops the code that handles ENV unsetting:
depends/toolchain.cmake.in
cmake/module/Maintenance.cmake