cmake: Fix passing linker flags in TryAppendCXXFlags module
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linker flags should be passed via `CMAKE_REQUIRED_LINK_OPTIONS` rather than `CMAKE_REQUIRED_FLAGS`.
vasild
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
ACK 41b5436
CMAKE_REQUIRED_LINK_OPTIONS is documented in https://cmake.org/cmake/help/latest/module/CheckCXXSourceCompiles.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linker flags should be passed via
CMAKE_REQUIRED_LINK_OPTIONSrather thanCMAKE_REQUIRED_FLAGS.The issue has been reported by fanquake offline.