Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Clarify documention regarding libqrencode optional dependency #296

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Aug 2, 2024

This PR addresses this feedback:

It seems that the bitcoin-qt qrencode dependency default value deviates from the one in autotools. I don't have the qrencode library available in my system and I'm able to compile the gui out of the box through autotools but not through cmake due to the missing dependency. It would be nice to use the same default value for now. And discuss any possible default value change (if needed) in a follow-up.

@hebasto
Copy link
Owner Author

hebasto commented Aug 2, 2024

cc @furszy @theStack

@hebasto hebasto added the documentation Docs and manuals label Aug 2, 2024
doc/build-freebsd.md Outdated Show resolved Hide resolved
@hebasto hebasto force-pushed the 240730-cmake-HS branch 2 times, most recently from da05cc5 to 316197a Compare August 3, 2024 09:26
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me.

doc/build-netbsd.md Outdated Show resolved Hide resolved
@m3dwards
Copy link

m3dwards commented Aug 5, 2024

LGTM!

@hebasto hebasto merged commit 874e21e into cmake-staging Aug 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs and manuals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants