cmake: Fix cross-compiling detection on OpenBSD #300
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To detect cross-compiling, the host and build platforms are compared. The `build` variable is always an output of `config.sub`, but the `host` is not. This can lead to false results. For example, on OpenBSD: - host=amd64-unknown-openbsd7.5 - build=x86_64-unknown-openbsd7.5 This change replaces the `host` variable with `canonical_host`, which is also always an output of `config.sub`. Thus, `canonical_host` and `build` are always properly comparable.
|
Friendly ping @theStack who reported this bug offline. |
|
Drafted as this PR breaks cross-compiling convention for Guix builds:
|
|
More correct change is here: bitcoin#30584. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect cross-compiling, the host and build platforms are compared. The
buildvariable is always an output ofconfig.sub, but thehostis not. This can lead to false results. For example, on OpenBSD:This change replaces the
hostvariable withcanonical_host, which is also always an output ofconfig.sub. Thus,canonical_hostandbuildare always properly comparable.There are a few same/similar cases in the master branch. So I'm going to investigate them further. and submit a PR.