cmake, doc: Document log output for failed tests #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe log output for failed tests.
hebasto
added
documentation
Yes, it is not used now. My question implies a need to update this line: bitcoin/src/test/CMakeLists.txt Line 199 in 7c23041 |
C++ does not print the backtrace on a segmentation fault (or other issue), like other languages like Rust ( So this is not useless. In any case, changing this seems unrelated to the migration. The previous behavior should be matched here. If there was reason to change it, it could be done in a follow-up. |
Hmm, not for me: --- i/src/test/net_tests.cpp
+++ w/src/test/net_tests.cpp
@@ -45,4 +45,5 @@ BOOST_AUTO_TEST_CASE(cnode_listen_port)
uint16_t altPort = 12345;
BOOST_CHECK(gArgs.SoftSetArg("-port", ToString(altPort)));
+ assert(0);
port = GetListenPort();
BOOST_CHECK(port == altPort);Without With |
You will have to use the other options as well. For example |
|
To clarify, the catch_system_error comes from #329 (comment) |
|
Again, the only difference between:
and
is an extra clutter in the second case. The checkpoint is not printed in either case (when Can you show the exact commands and their output that demonstrate that adding |
|
Again, you'll have to use the exact same options as the ctest command in #329 (comment) and compare it to the automake command. Using something else will give another result. For example, you are specifying the test case, so there is only one test running. However, ctest specifies a test suite. Also, Thus, the commands to compare would be: and |
|
The last checkpoint is not printed for neither of the above commands 👀 |
|
Ah right, the log level for that would be |
Sure, see below, where I test this with a segfault. Omitting the log level doesn't give any hint where the issue happened. However, with the log level, one can at least see the unit test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the master branch,
make checkgenerates afoo_tests.logfile for eachfoo_tests.cpp. These log files are only printed when a test fails. Since no one has raised concerns about the log file renaming in bitcoin#19385, these files appear to serve no other purpose.CTest provides its own mechanisms for logging failed tests, making the creation of
foo_tests.logfiles unnecessary.This PR documents these CTest logging mechanisms.
An example of output with a mocked test error:
A question for reviewers: Do we really need the
--log_level=test_suiteoption for these logs?