Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Allow configuration of sync peers #1274

Open
Vagabond opened this issue Mar 4, 2022 · 3 comments
Open

Allow configuration of sync peers #1274

Vagabond opened this issue Mar 4, 2022 · 3 comments
Assignees

Comments

@Vagabond
Copy link
Contributor

Vagabond commented Mar 4, 2022

When syncing the whole chain, most nodes do not have the older blocks, so it would be useful when doing a full sync to have a set of "sync peers" the node would use to sync against that are known to have a complete chain.

@anthonyra
Copy link

anthonyra commented Apr 22, 2022

I started something here that's meant to accomplish a similar goal, #1261

@joecaswell
Copy link
Contributor

My work on using a configured list is on branch https://github.com/helium/blockchain-core/tree/jc/sync-peer-configuration-option, it looks like #1261 is about finding an appropriate oldest sync source height for the local node, which is definitely useful information. My work is on limiting sync to the selected group of peers. If we had a way to request/send the information gathered by your changes, we could combine these into an automated peer selection facility that would be significantly better than random.

@anthonyra
Copy link

My original intentions that I never did get around to implementing was to gossip the height around to the other nodes. It'd be collected in the peerbook kind of like the current_height is. It would then allow nodes to filter their peerbook to the peers with heights within range of their current sync. I can see where yours uses a pre configured list of peers to sync from. I'd agree if both got implemented syncing would be significantly better

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants