-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Webhooks & EnhancedTransactions): Improved Test Coverage for Webhooks and Enhanced Transactions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est handler cannot Deserialise an empty response body
davidkathoh
changed the title
Improved Test Coverage #15
Test(webhooks & EnhancedTransactions): add test for webhooks and enhancedTransactions
May 20, 2024
0xIchigo
changed the title
Test(webhooks & EnhancedTransactions): add test for webhooks and enhancedTransactions
test(Webhooks & EnhancedTransactions): Improved Test Coverage for Webhooks and Enhanced Transactions
May 21, 2024
…-issues fix(webhooks): Update URL Formatting
…-deser fix(request_handler) Handle Empty Response Body
0xIchigo
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based PR. I've requested a few small changes, but very nice overall! 🔥
…est handler cannot Deserialise an empty response body
# Conflicts: # tests/test_enhanced_transactions.rs # tests/webhook/test_append_addresses_to_webhook.rs # tests/webhook/test_create_webhook.rs # tests/webhook/test_delete_webhook.rs # tests/webhook/test_edit_webhook.rs # tests/webhook/test_get_all_webhooks.rs # tests/webhook/test_get_webhook_by_id.rs # tests/webhook/test_remove_addresses_from_webhook.rs
I think all should be good now |
0xIchigo
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Thank you for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EnhanceTransaction and Webhook test #15