Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Webhooks & EnhancedTransactions): Improved Test Coverage for Webhooks and Enhanced Transactions #24

Merged
merged 32 commits into from
May 24, 2024

Conversation

davidkathoh
Copy link
Contributor

Added EnhanceTransaction and Webhook test #15

@davidkathoh davidkathoh changed the title Webhook test Improved Test Coverage #15 May 20, 2024
@davidkathoh davidkathoh changed the title Improved Test Coverage #15 Test(webhooks & EnhancedTransactions): add test for webhooks and enhancedTransactions May 20, 2024
@0xIchigo 0xIchigo changed the title Test(webhooks & EnhancedTransactions): add test for webhooks and enhancedTransactions test(Webhooks & EnhancedTransactions): Improved Test Coverage for Webhooks and Enhanced Transactions May 21, 2024
@0xIchigo 0xIchigo self-requested a review May 21, 2024 04:31
Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based PR. I've requested a few small changes, but very nice overall! 🔥

.idea/.gitignore Outdated Show resolved Hide resolved
.idea/helius-rust-sdk.iml Outdated Show resolved Hide resolved
.idea/modules.xml Outdated Show resolved Hide resolved
.idea/vcs.xml Outdated Show resolved Hide resolved
tests/test_enhanced_transactions.rs Outdated Show resolved Hide resolved
tests/webhook/test_delete_webhook.rs Outdated Show resolved Hide resolved
# Conflicts:
#	tests/test_enhanced_transactions.rs
#	tests/webhook/test_append_addresses_to_webhook.rs
#	tests/webhook/test_create_webhook.rs
#	tests/webhook/test_delete_webhook.rs
#	tests/webhook/test_edit_webhook.rs
#	tests/webhook/test_get_all_webhooks.rs
#	tests/webhook/test_get_webhook_by_id.rs
#	tests/webhook/test_remove_addresses_from_webhook.rs
@davidkathoh
Copy link
Contributor Author

I think all should be good now

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@0xIchigo
Copy link
Collaborator

Thank you for your contribution!

@0xIchigo 0xIchigo merged commit 0e80429 into helius-labs:dev May 24, 2024
1 check passed
@0xIchigo 0xIchigo mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants