-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "" to act as a pair for mim #4475
Comments
Would require |
Perhaps |
Interestingly, I did try that, but after compile it wasn't working. I noticed that we have no cases where open and close characters are identical, and I wonder if the existing code is not setup to handle this case. |
@lukepighetti your are right. I will try to take a look over the weekend 👀 |
Looks like @sudormrfbin was the last to touch this part of the codebase. Maybe he has some tips for us. |
Note for future implementors, adding any character pair (same or not) to the |
This doesn't seem completely fixed yet. Here I show examples in python and rust on the latest master. I have working LSPs for both languages.
For testing: foo_python = "mim does not work on this string" let foo_rust = "mim only works when the cursor is positioned on the first \"" I observe that |
Those two things are unrelated. The python case has an odd grammar for the string literal which is not being handeled due to an existing bug kn U don't think it's useful to necormamce old issues that are mostly solved except some edgecase burried kn the comments. |
@thomasaarholt hey, thanks for the reproduction steps. |
@pascalkuthe, the main reason I didn't create a new issue was that this one was closed 48 hours ago. I was honestly worried about being told off for making a new issue, which is why I commented here. 🤷 @woojiq, thank you! I really appreciate your contribution, it's one that makes helix feel even more intuitive to me! |
If you have the text
("yoo█oo")
with your cursor placed in the middle and usemim
, it will select inside the parens instead of inside the quotes. Expected result is to act inside the quoteshelix 22.08.1 (66276ce)
The text was updated successfully, but these errors were encountered: