-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCS changes picker #5362
Comments
I think we should use |
I agree that it would be nice to keep it consistent here altough it also feels kind of bad repeatly moving the debug binding around. It was just recently moved from |
I totally understand that, but it feels like it's worth putting in the effort to find it a forever home, and it is still an experimental feature so I would expect folks to be open to a little minor chaos |
|
After looking at #5472 I think we need 2/3 pickers:
IMHO picker 1 is actually the most useful - it's basically a Regarding key binding, I think binding to |
I can only find one keybinding dialog that is two levels deep, and that is Window via |
Actually. I changed my mind. I think pickers 2&3 are quite useless - for 2 you might as well just do That's why in my PR implementing 1 (#5645), I actually just did the |
I don't agree at all, all three pickers are useful, and the numbers of reactions on my initial message say I'm not the only one who thinks so. We have workspace and current file diagnostic pickers despite navigation+file picker bringing the same functionalities, dismissing the VCS ones simply because you prefer navigation is not a good argument. Not everyone has the same workflow or preferences in how they use their tools. We can have both modified files and modified blocks (current, workspace) pickers and only bind one of them by default if we want to avoid cluttering the keybinds (and that's a good idea), but arguing against them when wholly we already have equivalent is shortsighted IMO. Sorry if that comes off too strongly, I'm not intending to insult anyone, I just want to be sure to remind everyone that helix is not used only by its developers and that "I don't see a use for that therefore it is useless" it not a good argument when people have expressed a used for "that" and taken time to make issues and PRs |
When I code I often need to go back to the places I modified.
Now that helix supports VCS (i.e., git for now), we could add a VCS picker that would list all changes, for easy navigation.
For the sorting order I propose:
Including the first line of the change (or the line just before the deletion) would probably help searching too:
path/to/file:73 fn added_function() {
I have no idea what to pick for the picker key,
Space + v
maybe ?The text was updated successfully, but these errors were encountered: