Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid hexcodes in several themes emacs, monokai_aqua, papercolor-light (Should be checked in CI at theme PRs?) #5709

Closed
LeoniePhiline opened this issue Jan 27, 2023 · 1 comment · Fixed by #11627
Labels
C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Extra attention is needed

Comments

@LeoniePhiline
Copy link
Contributor

LeoniePhiline commented Jan 27, 2023

Reproduction:

  1. Open two terminals side by side
  2. In one terminal, watch the hx log: tail -f ~/.cache/helix/helix.log
  3. In the other terminal, open hx
  4. Type :theme
  5. Use the Tab key to go through all themes and observe the log.

Theme emacs

helix_view::theme [WARN] Theme: malformed hexcode: highlight

Theme monokai_aqua

helix_view::theme [WARN] Theme: malformed hexcode: light-black
helix_view::theme [WARN] Theme: malformed hexcode: light-black
helix_view::theme [WARN] Theme: malformed hexcode: purple

Theme papercolor-light

helix_view::theme [WARN] Theme: malformed hexcode: indent

Note: Logging the affected theme's name could be helpful! (Edit: But looking at the code, it seems unwieldy to carry the theme name around as much as would be necessary to log it in case of parsing errors.)


I assume this should be checked in CI via xtask.

@LeoniePhiline LeoniePhiline changed the title Invalid hexcodes in several themes (Should be checked in CI at theme PRs?) Invalid hexcodes in several themes emacs, monokai_aqua, papercolor-light (Should be checked in CI at theme PRs?) Jan 28, 2023
@kirawi kirawi added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Extra attention is needed labels Feb 5, 2023
@sarsapar1lla
Copy link
Contributor

Does this issue still require attention? If so, happy to take a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants