Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch with defaults instead of not launching upon invalid config/theme #670

Closed
Omnikar opened this issue Aug 28, 2021 · 1 comment · Fixed by #982
Closed

Launch with defaults instead of not launching upon invalid config/theme #670

Omnikar opened this issue Aug 28, 2021 · 1 comment · Fixed by #982
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@Omnikar
Copy link
Contributor

Omnikar commented Aug 28, 2021

If the user tries to start the editor and there is a problem with their config, I think the editor should start with the default config instead of failing to launch. That way, they don't have to use a different editor to fix the problematic config. Likewise, launch with the default theme if their configured theme is problematic. Of course, the editor should issue a warning on startup if either of these situations occur. Also, if the user tries to switch to a problematic theme with :theme, inform them and continue with the current theme instead of panicking.

@Omnikar Omnikar added the C-enhancement Category: Improvements label Aug 28, 2021
@Omnikar
Copy link
Contributor Author

Omnikar commented Aug 28, 2021

How would we go about displaying the startup error to the user? Statusline message on startup? Or display the message to the user and have them press enter to continue and start the editor? I think the latter, as a problematic theme or config is important enough to require explicit acknowledgement by the user.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants