Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDarker are difficult to distinguish code and inlay hints based color #7432

Closed
gobraves opened this issue Jun 23, 2023 · 4 comments · Fixed by #7433
Closed

OneDarker are difficult to distinguish code and inlay hints based color #7432

gobraves opened this issue Jun 23, 2023 · 4 comments · Fixed by #7433
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements

Comments

@gobraves
Copy link
Contributor

gobraves commented Jun 23, 2023

It is difficult to differentiate between hints and code in the onedarker theme based on colors.

I I referenced #6503 and added "ui.virtual.inlay-hint" = { fg = "light-gray" }

the original theme:
image

the new theme:
image

I could commit pr, if the team agrees that this should be changed.

@gobraves gobraves added the C-enhancement Category: Improvements label Jun 23, 2023
@gobraves gobraves changed the title OneDarker inlay hints are difficult to distinguish colors from the code. OneDarker inlay hints are difficult to distinguish code and inlay hints based color Jun 23, 2023
@gobraves gobraves changed the title OneDarker inlay hints are difficult to distinguish code and inlay hints based color OneDarker are difficult to distinguish code and inlay hints based color Jun 23, 2023
@the-mikedavis
Copy link
Member

That change looks fine to me. What do you think @nuid64?

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Jun 23, 2023
@nuid64
Copy link
Contributor

nuid64 commented Jun 23, 2023

That's cool. Thanks for asking, @the-mikedavis , and thanks for improvement, @gobraves .

@shbfy
Copy link

shbfy commented Jun 25, 2023

This issue is also present in the monokai, and monokai_aqua themes.

@lauglam
Copy link

lauglam commented Jun 26, 2023

This issue is also present in the monokai, and monokai_aqua themes.

Yes, this issue comes up in many theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants