fix: for undefined set and id (binary-com#16360)

henry-deriv · Aug 6, 2024 · 8a6161b · 8a6161b
1 parent fffe035
commit 8a6161b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/bot-skeleton/src/scratch/hooks/workspace_svg.js b/packages/bot-skeleton/src/scratch/hooks/workspace_svg.js
@@ -65,7 +65,7 @@ Blockly.WorkspaceSvg.prototype.centerOnBlock = function (id, hideChaff = true) {
         Blockly.hideChaff();
     }
 
-    this.scrollbar.set(scrollToCenterX, scrollToCenterY);
+    this?.scrollbar?.set(scrollToCenterX, scrollToCenterY);
 };
 
 /**

diff --git a/packages/bot-skeleton/src/scratch/utils/index.js b/packages/bot-skeleton/src/scratch/utils/index.js
@@ -458,16 +458,16 @@ export const scrollWorkspace = (workspace, scroll_amount, is_horizontal, is_chro
         */
 
         if (window.innerWidth < 768) {
-            workspace.scrollbar.set(0, scroll_y);
+            workspace?.scrollbar?.set(0, scroll_y);
             const calc_scroll =
                 workspace.svgBlockCanvas_?.getBoundingClientRect().width -
                 workspace.svgBlockCanvas_?.getBoundingClientRect().left +
                 60;
-            workspace.scrollbar.set(calc_scroll, scroll_y);
+            workspace?.scrollbar?.set(calc_scroll, scroll_y);
             return;
         }
     }
-    workspace.scrollbar.set(scroll_x, scroll_y);
+    workspace?.scrollbar?.set(scroll_x, scroll_y);
 };
 
 /**

diff --git a/packages/bot-web-ui/src/stores/app-store.ts b/packages/bot-web-ui/src/stores/app-store.ts
@@ -292,7 +292,7 @@ export default class AppStore {
                                 .filter(block => block.type === 'trade_definition_market')
                                 .forEach(block => {
                                     runIrreversibleEvents(() => {
-                                        const fake_create_event = new window.Blockly.Events.BlockCreate(this);
+                                        const fake_create_event = new window.Blockly.Events.BlockCreate(block);
                                         window.Blockly.Events.fire(fake_create_event);
                                     });
                                 });

diff --git a/packages/bot-web-ui/src/stores/toolbox-store.ts b/packages/bot-web-ui/src/stores/toolbox-store.ts
@@ -136,7 +136,7 @@ export default class ToolboxStore {
                 const workspace_metrics = workspace.getMetrics();
                 const block_canvas_space =
                     workspace_metrics.scrollWidth + workspace_metrics.viewLeft - workspace_metrics.viewWidth;
-                workspace.scrollbar.set(block_canvas_space, scroll_y);
+                workspace?.scrollbar?.set(block_canvas_space, scroll_y);
             }
         }
     }