Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Compatibility with self-hosted Omnivore installs #23

Closed
r0bbie opened this issue Nov 19, 2023 · 5 comments · Fixed by #25
Closed

Suggestion: Compatibility with self-hosted Omnivore installs #23

r0bbie opened this issue Nov 19, 2023 · 5 comments · Fixed by #25

Comments

@r0bbie
Copy link

r0bbie commented Nov 19, 2023

Firstly, great extension! Simple, nice UX that just works (and is much better than the official Firefox extension! which honestly this should just become..)

Would it be possible to add a setting to allow this to be used with a self-hosted Omnivore install (i.e. an additional setting in extension prefs to override default Omnivore instance with a self-hosted one, and provide accompanying API key for self-hosted install)?

While Omnivore doesn't seem quite there yet in terms of effective self-hosting, seems like it's getting there, and would be a shame not to be able to keep using this extension!

@herrherrmann
Copy link
Owner

Hey there! Thanks for the praise.

It would definitely be easy to add this additional option, sure! Are you already self-hosting Omnivore, or is this a "future-proofing" suggestion?

@herrherrmann
Copy link
Owner

@r0bbie In version 1.3.0 I now implemented an option to set the API URL in the extension settings. I haven’t tested it with a custom instance yet though (because I don’t have one), and I could imagine that the extension still needs some additional permissions to work with it. It’d be nice if you could test it once version 1.3.0 is released (that should happen today or tomorrow).

@xiaogaozi
Copy link

xiaogaozi commented Aug 15, 2024

Just FYI, if you use Chrome (or any Chromium-based browser) and set a custom API URL, an error will be reported when requesting this URL because it does not meet the CORS policy (as shown in the figure):

CleanShot 2024-08-15 at 16 36 02@2x

One solution is to modify the host_permissions in the manifest.chrome.json file and add your custom API URL to this field. However, you can't directly install the extension in the Chrome Web Store. You must fork the repository and build your own extension locally. Just run TARGET=chrome npm run build command to build the extension, it's very easy.

@herrherrmann
Copy link
Owner

@xiaogaozi Yes, you’re right that the extension permissions don’t allow for custom domains at the moment. I’ve looked into this back then and also couldn’t find any solution to make this work without rebuilding the extension yourself. Perhaps it would be more honest to remove the custom API url setting, to not confuse users. 🤔

@xiaogaozi
Copy link

For me personally, I really need the ability to customize API URL. "Omnivore List Popup" is the only Chrome extension I can currently find that supports this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants