From e942ec7c6255350143683dc120f3c2f6f567648a Mon Sep 17 00:00:00 2001 From: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Date: Wed, 15 Sep 2021 15:32:41 -0700 Subject: [PATCH] Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706) * Make ServiceName optional for verify-changelog In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty. * Put quotes around the strings to allow for empty Co-authored-by: Wes Haggard --- eng/common/pipelines/templates/steps/verify-changelog.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/common/pipelines/templates/steps/verify-changelog.yml b/eng/common/pipelines/templates/steps/verify-changelog.yml index 8173c8ec599b..887ad1a97d90 100644 --- a/eng/common/pipelines/templates/steps/verify-changelog.yml +++ b/eng/common/pipelines/templates/steps/verify-changelog.yml @@ -4,7 +4,7 @@ parameters: default: 'not-specified' - name: ServiceName type: string - default: 'not-specified' + default: '' - name: ServiceDirectory type: string default: '' @@ -17,10 +17,10 @@ steps: inputs: filePath: $(Build.SourcesDirectory)/eng/common/scripts/Verify-ChangeLog.ps1 arguments: > - -PackageName ${{ parameters.PackageName }} - -ServiceDirectory ${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }} + -PackageName '${{ parameters.PackageName }}' + -ServiceDirectory '${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}' -ForRelease $${{ parameters.ForRelease }} pwsh: true workingDirectory: $(Pipeline.Workspace) displayName: Verify ChangeLogEntry for ${{ parameters.PackageName }} - continueOnError: false \ No newline at end of file + continueOnError: false