Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout of @sidebar as aside within main is failing DAC assessment #127

Open
nubz opened this issue Jun 25, 2019 · 0 comments
Open

Layout of @sidebar as aside within main is failing DAC assessment #127

nubz opened this issue Jun 25, 2019 · 0 comments

Comments

@nubz
Copy link

nubz commented Jun 25, 2019

https://github.com/hmrc/play-ui/blob/master/src/main/twirl/uk/gov/hmrc/play/views/layouts/MainContent.scala.html accepts Html content for sidebar - it then renders an aside element within the main element to contain the Html content.

Our DAC assessment is failing us because of this layout, we have been pointed to wai-aria guidance on usage of asides: https://www.w3.org/TR/wai-aria-practices-1.1/#aria_lh_complementary

DAC-report-aside-failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant