From a65277e4f980ba08dc8606a9f7bcc92ed132a607 Mon Sep 17 00:00:00 2001 From: hoonoh Date: Tue, 7 Dec 2021 07:37:19 +0900 Subject: [PATCH] chore: eslint related cleanup --- .eslintrc.yml | 1 + src/cli.ts | 1 - src/lib/core.ts | 2 -- src/lib/ui.spec.ts | 7 ++++--- test/mock-credential-endpoints.ts | 1 - test/utils.ts | 4 +--- 6 files changed, 6 insertions(+), 10 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 9042994e..cb77d456 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -38,6 +38,7 @@ rules: # eslint-plugin-unused-imports '@typescript-eslint/no-unused-vars': off + '@typescript-eslint/no-explicit-any': off unused-imports/no-unused-imports-ts: error unused-imports/no-unused-vars-ts: - warn diff --git a/src/cli.ts b/src/cli.ts index a324102d..f6f43e6f 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -30,7 +30,6 @@ import { } from './module'; // https://github.com/yargs/yargs/issues/1519 -// eslint-disable-next-line no-underscore-dangle, @typescript-eslint/no-explicit-any (process.stdout as any)._handle.setBlocking(true); export const main = (argvInput?: string[]): Promise => diff --git a/src/lib/core.ts b/src/lib/core.ts index e97a59b8..602e3cd4 100644 --- a/src/lib/core.ts +++ b/src/lib/core.ts @@ -63,7 +63,6 @@ export class Ec2SpotPriceError extends Error { readonly ec2SpotPriceError = true; - // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types static isEc2SpotPriceError(error: any): error is Ec2SpotPriceError { return !!error.ec2SpotPriceError; } @@ -73,7 +72,6 @@ export class Ec2SpotPriceError extends Error { readonly code: string; } -// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types export const isAWSError = (error: any): error is AWSError => !!error.code; const getEc2SpotPrice = async (options: { diff --git a/src/lib/ui.spec.ts b/src/lib/ui.spec.ts index ba99380d..4e24a5db 100644 --- a/src/lib/ui.spec.ts +++ b/src/lib/ui.spec.ts @@ -9,10 +9,11 @@ import { import { ui } from './ui'; const getFamilySize = (family: string[]): string[] => { + const instanceFamilyCopy: Record = Object.fromEntries( + Object.entries(instanceFamily).map(([k, v]) => [k, [...v]]), + ); const types = Object.keys(instanceFamily).reduce((list, f) => { - // eslint-disable-next-line @typescript-eslint/ban-ts-comment - // @ts-ignore - if (family.includes(f)) return list.concat(instanceFamily[f] as string[]); + if (family.includes(f)) return list.concat(instanceFamilyCopy[f] as string[]); return list; }, [] as string[]); const instances = allInstances.filter(i => types.includes(i.split('.').shift() as string)); diff --git a/test/mock-credential-endpoints.ts b/test/mock-credential-endpoints.ts index 3de86c46..38966384 100644 --- a/test/mock-credential-endpoints.ts +++ b/test/mock-credential-endpoints.ts @@ -13,7 +13,6 @@ export const mockAwsCredentials = ( config.credentials = null; const mock = (): void => { - // eslint-disable-next-line @typescript-eslint/no-explicit-any readFileSyncMock = jest.spyOn(fs, 'readFileSync').mockImplementation((...args: any) => { const path = args[0] as string; if (!path.includes(`${sep}.aws${sep}`)) { diff --git a/test/utils.ts b/test/utils.ts index 000635ba..26efa753 100644 --- a/test/utils.ts +++ b/test/utils.ts @@ -1,7 +1,5 @@ export const consoleMockCallJoin = (type: 'log' | 'warn' | 'error' = 'log'): string => { - // eslint-disable-next-line @typescript-eslint/ban-ts-comment - // @ts-ignore - const { calls }: { calls: string[][] } = console[type].mock; + const { calls }: { calls: string[][] } = (console[type] as any).mock; if (calls) return calls.map(sa => sa.join(' ')).join('\n'); return ''; };