Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings Cycler] Nested settings are clobbered, and should be merged instead #11

Open
forivall opened this issue Mar 6, 2019 · 0 comments

Comments

@forivall
Copy link

forivall commented Mar 6, 2019

[background info, as the issue was at first that it's not working, but then i figured it out. see below. join me on this small adventure]

I'm trying to cycle colorCustomizations, but it seemed to not be working. The setting is

    "workbench.colorCustomizations": {
        "editorIndentGuide.activeBackground": "#969896",
        "editorWarning.foreground": "#de935f40",
    },

and the cycling settings i've tried are

    "settings.cycle": [{
        "id": "warningSquiggles",
        "overrideWorkspaceSettings": true,
        "values": [{
            "workbench.colorCustomizations.editorWarning.foreground": "#de935f",
            "workbench.colorCustomizations.editorError.foreground": "#d13b2e",
        }, {
            "workbench.colorCustomizations.editorWarning.foreground": "#de935f20",
            "workbench.colorCustomizations.editorError.foreground": "#d13b2e20",
        }]
    }],

and (which worked!)

    "settings.cycle": [{
        "id": "warningSquiggles",
        "overrideWorkspaceSettings": true,
        "values": [{
            "workbench.colorCustomizations": {
                "editorWarning.foreground": "#de935f",
                "editorError.foreground": "#d13b2e"
            },
        }, {
            "workbench.colorCustomizations": {
                "editorWarning.foreground": "#de935f40",
                "editorError.foreground": "#d13b2e40"
            }
        }]
    }],

However, even though this works, if i were to have other colour customizations, they are clobbered and removed.

Thanks for the extension, it does the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant