Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss311 test 01 02 #318

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Iss311 test 01 02 #318

wants to merge 6 commits into from

Commits on Jan 3, 2020

  1. Created test cases for Issue hpc#311

    Only two test cases so far:
    
    - The first test case shows the difference between GNU find and HPC
    dfind in handling spaces with file names.
    
    - The second test case illustrates the issue that dfind --exec does not
    permit standard redirection of stderr output by a command forked to
    exec.
    novak5-llnl committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    a522f67 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'iss311'

    These are test cases for the hpc dfind command.  There are two test
    cases:
    
    - Check for compatibility of --exec handling spaces in filenames
    compared to GNU find
    - Check for redirection of stderr output from --exec commands which
    appears to fail.
    sailnfool committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    f0cc015 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Made the script easier to read

    I also fixed a bug with find vs. $GFIND
    sailnfool committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    ff4ec3f View commit details
    Browse the repository at this point in the history
  2. Testing for Issue 311

    Testing for Issue hpc#311
    
    Using the parameters from test_dcp/test_fiemap.sh as a starting point.
    The test template uses a makefile to harness the tests.
    
    Two Tests implemented:
    
    1) Test for the correct handling of hpc dfind vs. GNU find for having
    blanks in file names when passing files to --exec. Only a single thread
    is
    needed to illustrate the error.
    
    2) Test that illustrates that stderr redirection is incorrect for
    hpc dfind vs. GNU find.
    This will later be reported as a separate issue and the second test will
    be placed on a branch to repair that issue.
    
    Binaries under test are found in mpifileutils/../install (per normal
    build).
    Test scripts, source and destination files under ../test, e.g.
    ../test/bin for scripts/binaries
    ../test/src for test inputs
    ../test/dest for test output
    
    The test harness scripts accept the following parameters:
    	-DFIND_TEST_BIN        - the hpc binary under test, found in
                               mpifileutils/../install
    	-DFIND_MPIRUN_BIN      - for mpirun vs. srun
    	-DFIND_CMP_BIN         - for the result comparison program (e.g.
    diff)
    	-DFIND_SRC_DIR         - for the test input files
    	-DFIND_DEST_DIR        - for the test output files
    	-DFIND_TMP_FILE        - in this case for the constructed script
    file
    	-DFIND_TESTING_BIN_DIR - for the directory where test
    executables and scripts
    	                         are placed
    	-DFIND_TEST_NUMBER     - The test number so we can re-sequence
    testing
    	-GNU_FIND_BIN          - The GNU binary that we use for
    comparison
    sailnfool committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    6327618 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Use strings to make sure we have the GNU...

    Use the strings command to insure that we have the GNU version of the
    find command to test against.  Also verify that the diff command came
    from GNU as well.
    sailnfool committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    133d3df View commit details
    Browse the repository at this point in the history
  2. Testing for Issue hpc#311

    Using the parameters from test_dcp/test_fiemap.sh as a starting point.
    The test template uses a makefile to harness the tests.
    
    Two Tests implemented:
    
    1) Test for the correct handling of hpc dfind vs. GNU find for having
    blanks in file names when passing files to --exec. Only a single thread
    is
    needed to illustrate the error.
    
    2) Test that illustrates that stderr redirection is incorrect for
    hpc dfind vs. GNU find.
    This will later be reported as a separate issue and the second test will
    be placed on a branch to repair that issue.
    
    Binaries under test are found in mpifileutils/../install (per normal
    build).
    Test scripts, source and destination files under ../test, e.g.
    ../test/bin for scripts/binaries
    ../test/src for test inputs
    ../test/dest for test output
    
    The test harness scripts accept the following parameters:
    	-DFIND_TEST_BIN        - the hpc binary under test, found in
                               mpifileutils/../install
    	-DFIND_MPIRUN_BIN      - for mpirun vs. srun
    	-DFIND_CMP_BIN         - for the result comparison program (e.g.
    diff)
    	-DFIND_SRC_DIR         - for the test input files
    	-DFIND_DEST_DIR        - for the test output files
    	-DFIND_TMP_FILE        - in this case for the constructed script
    file
    	-DFIND_TESTING_BIN_DIR - for the directory where test
    executables and scripts
    	                         are placed
    	-DFIND_TEST_NUMBER     - The test number so we can re-sequence
    testing
    	-GNU_FIND_BIN          - The GNU binary that we use for
    comparison
    sailnfool committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    444ee15 View commit details
    Browse the repository at this point in the history