Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final changes before 1.0.0 #547

Closed
indexzero opened this issue Jan 11, 2014 · 4 comments
Closed

Final changes before 1.0.0 #547

indexzero opened this issue Jan 11, 2014 · 4 comments
Assignees

Comments

@indexzero
Copy link
Contributor

@yawnt found a few minor things when I was using this extensively:

  • EventEmitter3 will not throw on an unhandled error: but without any default handler it's very confusing to debug when your proxy logic is just plain wrong. We should have a default logger if there are no error handlers. cc/ @3rd-Eden
  • We should have a simple(r) .createProxy() method: which is basically just exposing createRightProxy. A lot of our users don't even bother with httpProxy.createServer, they just use new httpProxy.RoutingProxy(). Forcing them to create a server that they will never use feels very awkward.
  • Remove all (soon to be old) caronte links: The README.md and a few other doc links still have hrefs to the caronte branch
@ghost ghost assigned yawnt Jan 11, 2014
@jcrugzz
Copy link
Contributor

jcrugzz commented Jan 11, 2014

@indexzero running httpProxy.createServer() actually just creates a proxy. The only thing that makes it a "server" is by calling the .listen() method. This is one of the reasons I exposed the "server" on the main module.exports so you can just do..

var HttpProxy = require('http-proxy');

var proxy = new HttpProxy(options);

This allowed my OCD to calm down because it is now semantically correct in what you are creating.

@indexzero
Copy link
Contributor Author

@jcrugzz Thanks, but still want this.

@yawnt ping?

@yawnt
Copy link
Contributor

yawnt commented Jan 16, 2014

done, the onlyu references i've found to caronte are the images for test coverage and travis, and i think it's saner to change those post-merge

@indexzero
Copy link
Contributor Author

@yawnt Sold. Lets do the damn thing :-D

@yawnt yawnt closed this as completed in 4351ed1 Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants