Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with JRuby v9.2.0.0 due to problem with http_parser.rb v0.6.0. #475

Closed
clonezone opened this issue May 25, 2018 · 6 comments
Milestone

Comments

@clonezone
Copy link

See http_parser.rb bug report.

@ixti
Copy link
Member

ixti commented May 25, 2018

We have plans on switching http parser. If I will have some time this weekned - will try to work on that.

@janko janko mentioned this issue May 27, 2018
@jrochkind
Copy link
Contributor

Def interested in this working with jruby 9.2 asap, following.

@ixti ixti added this to the v5.0.0 milestone Oct 14, 2018
@ixti
Copy link
Member

ixti commented Feb 4, 2019

I have cut 5.0.0 pre release version of gem with switch to updated http parser. This should be fixed now.

@ixti ixti closed this as completed Feb 4, 2019
@jrochkind
Copy link
Contributor

Oh nice! Thanks!

Are there release notes or a URL to a relevant PR or commit about the changed http parser? I'm curious about the details, if what's used in MRI and Jruby both changed, to the same thing, what it is, etc.;

since previous http parser (at least in jruby?) was a third-party thing that ended up unmaintained, interested in looking at social context of the new parser and it's maintainance story.

@ixti
Copy link
Member

ixti commented Feb 4, 2019

This is the commit: f1db84f

Right now we switched to maintained ffi-based http parser: https://github.com/cotag/http-parser
But in future I plan on getting rid of 3rd party dependency and have our own ffi bindings to joyent's http parser (mostly because I don't like http-parser's (gem) API).

@jrochkind
Copy link
Contributor

Thanks! So nice to see http.rb getting maintenance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants