Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for commit signing? #916

Closed
agathish opened this issue Aug 4, 2020 · 1 comment · Fixed by #951
Closed

Add support for commit signing? #916

agathish opened this issue Aug 4, 2020 · 1 comment · Fixed by #951
Labels
enhancement good first issue

Comments

@agathish
Copy link

agathish commented Aug 4, 2020 •
edited
Loading

I am trying to sign commits using a GPG key. Is it possible to add support for commit signing?
The key should ideally be stored in externally. eg: ~/.github file used to store credentials.
@bitwiseman
Copy link
Member

bitwiseman commented Aug 4, 2020 •
edited
Loading

We can read the GHVerification from an existing commit.

When creating a commit via the GitHub API a signature can be passed. All that needs to be done is adding the a method to the GHCommitBuilder to take a signature.

I would suggest the method be something like withSignature(String). Then callers could provide that string from where ever.

@agathish
You are welcome to add this, I'll be happy to review any PRs.

@tginiotis-at-work tginiotis-at-work mentioned this issue Sep 30, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow adding signature to commits tginiotis-at-work/github-api
2 participants
@agathish @bitwiseman