Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable emojis/colour when CI env var is set #560

Open
achingbrain opened this issue Jul 5, 2023 · 2 comments
Open

Disable emojis/colour when CI env var is set #560

achingbrain opened this issue Jul 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@achingbrain
Copy link
Collaborator

achingbrain commented Jul 5, 2023

CI logging output can be really hard to read:

\x1B[0m\x1B[0m\n'
 \x1B[0m  ping test\x1B[0m\n'
   \x1B[36m  - should listen for ping\x1B[0m\n'

Some CI logging setups handle this well, some do not - the above is a browser test running in a docker image on GitHub CI so I think it's actually Docker which is mangling the output, at any rate it's full of garbage.

It would be better to disable all the fancy formatting when the process.env.CI env var is set. Some runners do this automatically (e.g. mocha) but others don't (playwright?).

Copy link
Owner

which test runner are you using ? can you post a link to that run please

@hugomrdias hugomrdias added the enhancement New feature or request label Jul 6, 2023 — with Volta.net
@achingbrain
Copy link
Collaborator Author

achingbrain commented Jul 26, 2023

They are mocha tests run in a browser via playwright test, running on Docker.

Here's an example run: https://github.com/libp2p/js-libp2p/actions/runs/5465156410/job/14796171888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants