Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

689 update codegangsta to urfave #690

Merged

Conversation

jshields
Copy link
Contributor

This PR seeks to address installation issues stemming from a Git repo that was renamed:
#689

The only remaining reference to the old name should be in this comment:
https://github.com/jshields/gobot/blob/master/api/basic_auth.go#L11

To update Gopkg.lock, I ran these commands:

brew install dep
dep ensure

I have no insight into why dep made all the changes it did to the lock file, aside from removing the old dependency name and adding the new one. Here is the version I am using:

dep version
dep:
 version     : v0.5.4
 build date  : 2019-06-14
 git hash    : 1f7c19e
 go version  : go1.12.6
 go compiler : gc
 platform    : darwin/amd64
 features    : ImportDuringSolve=false

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #690 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #690   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files         158      158           
  Lines       10944    10944           
=======================================
  Hits         8459     8459           
  Misses       2030     2030           
  Partials      455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d6ea7...6edafef. Read the comment docs.

@MShoaei
Copy link
Contributor

MShoaei commented Oct 1, 2019

Why isn't this being merged?

@deadprogram
Copy link
Member

We need to switch to modules. In the meantime, merging this PR. Thank you for the contribution!

@deadprogram deadprogram merged commit f73774b into hybridgroup:dev Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants