From 864430c5dd453b70c29bb3d058e81876858380f4 Mon Sep 17 00:00:00 2001
From: Michael Rodler <mrodler@amazon.de>
Date: Fri, 9 Jun 2023 17:07:18 +0000
Subject: [PATCH] Enabled clippy in CI and ran `clippy --fix`

Signed-off-by: Michael Rodler <mrodler@amazon.de>
---
 .github/workflows/CI.yml   | 7 +++++++
 src/frame/data.rs          | 2 +-
 src/hpack/table.rs         | 6 +++---
 src/hpack/test/fixture.rs  | 2 +-
 src/lib.rs                 | 9 +++++++--
 src/proto/streams/state.rs | 8 ++++----
 6 files changed, 23 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
index 2cff15cf..e90c68af 100644
--- a/.github/workflows/CI.yml
+++ b/.github/workflows/CI.yml
@@ -65,6 +65,13 @@ jobs:
         run: cargo clean; cargo update -Zminimal-versions; cargo check
         if: matrix.rust == 'nightly'
 
+  clippy_check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: Run Clippy
+        run: cargo clippy --all-targets --all-features
+
   msrv:
     name: Check MSRV
     needs: [style]
diff --git a/src/frame/data.rs b/src/frame/data.rs
index d0cdf5f6..5ed3c31b 100644
--- a/src/frame/data.rs
+++ b/src/frame/data.rs
@@ -148,7 +148,7 @@ impl<T: Buf> Data<T> {
     ///
     /// Panics if `dst` cannot contain the data frame.
     pub(crate) fn encode_chunk<U: BufMut>(&mut self, dst: &mut U) {
-        let len = self.data.remaining() as usize;
+        let len = self.data.remaining();
 
         assert!(dst.remaining_mut() >= len);
 
diff --git a/src/hpack/table.rs b/src/hpack/table.rs
index a1a78045..3e45f413 100644
--- a/src/hpack/table.rs
+++ b/src/hpack/table.rs
@@ -319,7 +319,7 @@ impl Table {
             let mut probe = probe + 1;
 
             probe_loop!(probe < self.indices.len(), {
-                let pos = &mut self.indices[probe as usize];
+                let pos = &mut self.indices[probe];
 
                 prev = match mem::replace(pos, Some(prev)) {
                     Some(p) => p,
@@ -656,12 +656,12 @@ fn to_raw_capacity(n: usize) -> usize {
 
 #[inline]
 fn desired_pos(mask: usize, hash: HashValue) -> usize {
-    (hash.0 & mask) as usize
+    hash.0 & mask
 }
 
 #[inline]
 fn probe_distance(mask: usize, hash: HashValue, current: usize) -> usize {
-    current.wrapping_sub(desired_pos(mask, hash)) & mask as usize
+    current.wrapping_sub(desired_pos(mask, hash)) & mask
 }
 
 fn hash_header(header: &Header) -> HashValue {
diff --git a/src/hpack/test/fixture.rs b/src/hpack/test/fixture.rs
index 0d33ca2d..d3f76e3b 100644
--- a/src/hpack/test/fixture.rs
+++ b/src/hpack/test/fixture.rs
@@ -100,7 +100,7 @@ fn test_story(story: Value) {
             let mut input: Vec<_> = case
                 .expect
                 .iter()
-                .map(|&(ref name, ref value)| {
+                .map(|(name, value)| {
                     Header::new(name.clone().into(), value.clone().into())
                         .unwrap()
                         .into()
diff --git a/src/lib.rs b/src/lib.rs
index 83014711..7975ea8c 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -79,9 +79,14 @@
 //! [`client::handshake`]: client/fn.handshake.html
 
 #![doc(html_root_url = "https://docs.rs/h2/0.3.19")]
-#![deny(missing_debug_implementations, missing_docs)]
-#![cfg_attr(test, deny(warnings))]
+#![deny(
+    missing_debug_implementations,
+    missing_docs,
+    clippy::missing_safety_doc,
+    clippy::undocumented_unsafe_blocks
+)]
 #![allow(clippy::type_complexity, clippy::manual_range_contains)]
+#![cfg_attr(test, deny(warnings))]
 
 macro_rules! proto_err {
     (conn: $($msg:tt)+) => {
diff --git a/src/proto/streams/state.rs b/src/proto/streams/state.rs
index 6f89b34c..1ca8f5af 100644
--- a/src/proto/streams/state.rs
+++ b/src/proto/streams/state.rs
@@ -361,10 +361,10 @@ impl State {
     }
 
     pub fn is_remote_reset(&self) -> bool {
-        match self.inner {
-            Closed(Cause::Error(Error::Reset(_, _, Initiator::Remote))) => true,
-            _ => false,
-        }
+        matches!(
+            self.inner,
+            Closed(Cause::Error(Error::Reset(_, _, Initiator::Remote)))
+        )
     }
 
     /// Returns true if the stream is already reset.