Skip to content

Commit

Permalink
Merge pull request #1507 from bluetech/cp-parts-service
Browse files Browse the repository at this point in the history
Fix example & cherry-pick server::conn::Parts.service to master
  • Loading branch information
seanmonstar committed May 4, 2018
2 parents 7de3bc9 + 18c5f64 commit ef14a1b
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion examples/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ extern crate pretty_env_logger;
use std::env;
use std::io::{self, Write};

use hyper::{Body, Client, Request};
use hyper::Client;
use hyper::rt::{self, Future, Stream};

fn main() {
Expand Down
2 changes: 1 addition & 1 deletion src/client/conn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ where
///
/// Only works for HTTP/1 connections. HTTP/2 connections will panic.
pub fn into_parts(self) -> Parts<T> {
let (io, read_buf) = match self.inner {
let (io, read_buf, _) = match self.inner {
Either::A(h1) => h1.into_inner(),
Either::B(_h2) => {
panic!("http2 cannot into_inner");
Expand Down
7 changes: 4 additions & 3 deletions src/proto/h1/dispatch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pub(crate) trait Dispatch {

pub struct Server<S: Service> {
in_flight: Option<S::Future>,
service: S,
pub(crate) service: S,
}

pub struct Client<B> {
Expand Down Expand Up @@ -58,8 +58,9 @@ where
self.conn.disable_keep_alive()
}

pub fn into_inner(self) -> (I, Bytes) {
self.conn.into_inner()
pub fn into_inner(self) -> (I, Bytes, D) {
let (io, buf) = self.conn.into_inner();
(io, buf, self.dispatch)
}

/// The "Future" poll function. Runs this dispatcher until the
Expand Down
9 changes: 6 additions & 3 deletions src/server/conn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ where
/// This allows taking apart a `Connection` at a later time, in order to
/// reclaim the IO object, and additional related pieces.
#[derive(Debug)]
pub struct Parts<T> {
pub struct Parts<T, S> {
/// The original IO object used in the handshake.
pub io: T,
/// A buffer of bytes that have been read but not processed as HTTP.
Expand All @@ -110,6 +110,8 @@ pub struct Parts<T> {
/// You will want to check for any existing bytes if you plan to continue
/// communicating on the IO object.
pub read_buf: Bytes,
/// The `Service` used to serve this connection.
pub service: S,
_inner: (),
}

Expand Down Expand Up @@ -335,8 +337,8 @@ where
/// This should only be called after `poll_without_shutdown` signals
/// that the connection is "done". Otherwise, it may not have finished
/// flushing all necessary HTTP bytes.
pub fn into_parts(self) -> Parts<I> {
let (io, read_buf) = match self.conn {
pub fn into_parts(self) -> Parts<I, S> {
let (io, read_buf, dispatch) = match self.conn {
Either::A(h1) => {
h1.into_inner()
},
Expand All @@ -347,6 +349,7 @@ where
Parts {
io: io,
read_buf: read_buf,
service: dispatch.service,
_inner: (),
}
}
Expand Down

0 comments on commit ef14a1b

Please sign in to comment.