Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhelpful error when trying to send a body on a GET request #1955

Open
Demi-Marie opened this issue Sep 26, 2019 · 2 comments
Open

Unhelpful error when trying to send a body on a GET request #1955

Demi-Marie opened this issue Sep 26, 2019 · 2 comments

Comments

@Demi-Marie
Copy link

Demi-Marie commented Sep 26, 2019

#1926 was correct, but “channel closed” is not a helpful error message. Adding a new error that means “Request body not allowed” would be a significant help to users of the library.

@seanmonstar
Copy link
Member

It would be quite difficult to get that error message in, since internally hyper simply drops the body, and the channel version doesn't have a way to know the difference.

If it doesn't already, we could include a log message about the ambiguity.

@Demi-Marie
Copy link
Author

A log message might be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants