feat(client): rename client::Builder pool options
#2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is partly motivated by wanting to add HTTP2 keep-alive options, and the names |
seanmonstar
force-pushed
the
client-builder-rename-pool-options
branch
4 times, most recently
from
7512359
to
6c3a4fc
Compare
- Renamed `keep_alive_timeout` to `pool_idle_timeout`. - Renamed `max_idle_per_host` to `pool_max_idle_per_host`. - Deprecated `keep_alive(bool)` due to confusing name. To disable the connection pool, call `pool_max_idle_per_host(0)`.
seanmonstar
force-pushed
the
client-builder-rename-pool-options
branch
from
6c3a4fc
to
9525fca
Compare
seanmonstar
pushed a commit
to seanmonstar/reqwest
that referenced
this pull request
May 22, 2020
reqwest exposes the “pool_max_idle_per_host” option of hyper’s client builder. This option used to be called “max_idle_per_host” in the hyper crate, but it has recently been renamed [1]. This patch renames the reqwest representation of this option to make it consistent with its name in the hyper crate again. [1] hyperium/hyper#2142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keep_alive_timeouttopool_idle_timeout.max_idle_per_hosttopool_max_idle_per_host.keep_alive(bool)due to confusing name. To disable theconnection pool, call
pool_max_idle_per_host(0).