Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize Withdrawal Request Address #7288

Closed
Gabriel-Trintinalia opened this issue Jul 2, 2024 · 1 comment
Closed

Parameterize Withdrawal Request Address #7288

Gabriel-Trintinalia opened this issue Jul 2, 2024 · 1 comment
Assignees
@Matilda-Clerke
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Gabriel-Trintinalia
Copy link
Contributor

Gabriel-Trintinalia commented Jul 2, 2024 •
edited
Loading

Parameterize WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS on startup as the deposit request.

Context: Request made in this this comment of the System Call PR: #7263 (comment)

Probably used for devnets or any other network that has a different address for this contract.

Similar to depositContractAddress, which is in the genesis file.
@Gabriel-Trintinalia Gabriel-Trintinalia added enhancement New feature or request good first issue Good for newcomers labels Jul 2, 2024
@Gabriel-Trintinalia Gabriel-Trintinalia mentioned this issue Jul 2, 2024
Merged
@jflo
Copy link
Contributor

jflo commented Jul 2, 2024

Can we get some more detail here? I'm assuming we would want this for devnets. Should this be in the genesis config? Or is this a CLI override?

@Matilda-Clerke Matilda-Clerke self-assigned this Jul 19, 2024
@Matilda-Clerke Matilda-Clerke mentioned this issue Jul 22, 2024
Merged
7 tasks
@macfarla macfarla mentioned this issue Jul 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matilda-Clerke Matilda-Clerke

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jflo @Gabriel-Trintinalia @Matilda-Clerke