widgets: add Shape + minor image improve #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Similar to this has been on images before get fixed.
|
|
aye just wanted to ask vaxry if I need to glClear here too, will add |
|
я тоже понял |
vaxerski
approved these changes
Apr 9, 2024
|
maybe create FB no matter rotated or not? honestly looks a bit ugly on fade-in/fade-out when borderBox is bright and shape is dark (with alpha transition) |
|
you can, sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that's to close #253
nothing special, except xray
well, despite it's stupid to punch a hole in background, someone may find it useful
I've been messaged to share a config from #247 video for cava bars, and I think updating labels every 33 ms is much more stupid :D
anyways, it is a harmless option after all
shape.mp4
dunno, looks ok
also added some minor stuff to Image