Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Built Version 0.9.4 #185

Closed
Grabauskas opened this issue Oct 15, 2019 · 4 comments
Closed

Invalid Built Version 0.9.4 #185

Grabauskas opened this issue Oct 15, 2019 · 4 comments

Comments

@Grabauskas
Copy link

It seems like version 0.9.4 has some trash or not fully built.

https://unpkg.com/browse/notistack@0.9.4/build/SnackbarContainer/SnackbarContainer.js

25  |   var _constants = require('../utils/constants');
... |
50  |   renderVariant: _propTypes2.default.oneOf(Object.keys(_constants.RENDER_VARIANTS)),

This file using RENDER_VARIANTS from constants, but it's not defined.
https://unpkg.com/browse/notistack@0.9.4/build/utils/constants.js

@iamhosseindhv
Copy link
Owner

Thanks for reporting this @Grabauskas . This is trash and I'll publish thefix by the end of today. Is this causing any issues while using the library?

@Grabauskas
Copy link
Author

Yes, in JSPM this generated map line is invalid:

map: {
   "./build/SnackbarContainer": "./build/SnackbarContainer/index.js"
}

But I already fixed that with overwrites, removing this line.

@iamhosseindhv
Copy link
Owner

This is fixed in v0.9.5. would be good if you could confirm.

@Grabauskas
Copy link
Author

Thank you, now it works. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants