Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong locale for belgium #690

Closed
blaadje opened this issue Oct 10, 2019 · 2 comments
Closed

Wrong locale for belgium #690

blaadje opened this issue Oct 10, 2019 · 2 comments

Comments

@blaadje
Copy link

blaadje commented Oct 10, 2019

ATM BE locale (which should be belgium) seems to correspond to belarus where the country code is BY. It is problematic for us as we needs to make exception for this locale and use the FR one instead.

Expected behavior
I guess we should have by for belarus instead and having correct locale for be

Information

  • Dayjs v1.8.16
  • OS: MAC OS
  • Browser chrome 62
  • Time zone: [e.g. GMT-07:00 DST (Pacific Daylight Time)]
@iamkun
Copy link
Owner

iamkun commented Oct 11, 2019

Hi, according to ISO_639-2 code mentioned in #171 https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes

be is for Belarusian

while Dutch (Belgium) [nl-be] is for Belgium

@blaadje
Copy link
Author

blaadje commented Oct 23, 2019

Alright thanks for clarifying 👌

@blaadje blaadje closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants