Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract a common core between reference and evidence #237

Open
deeglaze opened this issue May 23, 2024 · 4 comments
Open

Extract a common core between reference and evidence #237

deeglaze opened this issue May 23, 2024 · 4 comments

Comments

@deeglaze
Copy link
Collaborator

deeglaze commented May 23, 2024

In PR#232 the addition "CoRIM data structures may be used by Evidence and Attestation Results that wish to describe overlapping structure" is particularly concerning. I've seen Ned describe the desire to avoid needing to define new translations between all new evidence formats by declaring that industry evidence formats are just always going to use CoRIM triples. That's not at all decided, and I think there are phase distinction concerns to address when trying to blend the provisioning+signing time and run time representations of both expectations and raw evidence.

Given that, just saying that "CoRIM data structures may be used" is certainly a possibility, but it's too hypothetical to solidify in the standard. When another entity decides their message representation, they are of course well within their rights to reuse CoRIM encodings, but without a standard to describe the common core between evidence, attestation results, and CoRIMs, it's too early to muddy the waters. A concrete example of the bleeding between reference and evidence is the mkey #230, and I don't think that it belongs there in the reference structure.

@nedmsmith
Copy link
Collaborator

The internal representation reuses ECTs for everything from evidence to endorsement to attestation results. The semantics of ECTs overlaps all the various conceptual messages. Hence, the idea of a schema that "overlaps" or in other words is multi-purpose isn't out of the question.

The TCG specs that define concise-evidence, DiceTcbInfo, and SPDM formats overlap portions of the CoRIM schema on purpose to ensure a mapping to the internal representation is (ideally) non-lossy. The definition of evidence that borrows some of the CDDL in CoRIM nevertheless relies on different CBOR tagging that distinguishes it as Evidence vs Reference or Endorsed Values (which is what the CBOR tagging in CoMID distinguish.

The language in section 8 is in the context of a description of appraisal processing where all the inputs are transformed into internal representations. This text is setting the stage for use of ECTs.

@henkbirkholz
Copy link
Member

Maybe referencing TCG concise-evidence as an example in the context of Dionna's proposed ""CoRIM data structures may be used" is good enough?

@deeglaze
Copy link
Collaborator Author

That still seems unguided. Is the goal not to converge on an industry standard attestation evidence format? Without that goal, we can see diverging uses of CoRIM CDDL codepoints.

@deeglaze
Copy link
Collaborator Author

Perhaps we can make a label for issues that are better handled in a "User guide" type of document to accompany the reference document? If we have that, I'd say label it that and close so we can come back to it in a follow-up doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants